docs: CLI generation workflow for ARO HCP - #6179
Conversation
…ons] generation and working with Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bennerv The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Pull request overview
This PR updates ARO-HCP documentation to describe the upstream Azure CLI (AAZ) generation/publishing workflow for the ARO HCP CLI, and applies a small wording fix in the API specs to correct a typo in nodepool label descriptions.
Changes:
- Rewrite
docs/cli-generation.mdto focus on the end-to-end upstream workflow (aaz command models + generated CLI artifacts) and ARO HCP-specific generation considerations. - Fix the “newly create” → “newly created” typo in both the OpenAPI and TypeSpec sources for nodepool label documentation.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| docs/cli-generation.md | Replaces the previous step-by-step command list with an overview of upstream repositories/artifacts and ARO HCP-specific CLI generation guidance. |
| api/redhatopenshift/resource-manager/Microsoft.RedHatOpenShift/hcpopenshiftclusters/preview/2024-06-10-preview/openapi.json | Corrects a typo in the nodepool labels description string. |
| api/redhatopenshift/resource-manager/Microsoft.RedHatOpenShift/hcpopenshiftclusters/hcpCluster-models.tsp | Corrects the same typo in the TypeSpec doc comment for nodepool labels. |
| ``` | ||
|
|
||
| Interpretation: | ||
| **Preview API versions** (e.g. `2025-12-23-preview`) produce an `aro-hcp` **extension** in `azure-cli-extensions`. Customers install it with `az extension add`. |
|
Ben Vesel (@bennerv): The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
| /** Kubernetes labels to propagate to the NodePool Nodes | ||
| * Note that when the labels are updated this is only applied to newly | ||
| * create nodes in the Nodepool, existing node labels remain unchanged. | ||
| * created nodes in the Nodepool, existing node labels remain unchanged. |
There was a problem hiding this comment.
There are a few more of these typos to be fixed across the other preview versions
Do we want to do those with this PR too?
Summary
Test plan
🤖 Generated with Claude Code