handle ARO-Tools SafeFly step type in templatize#6173
Conversation
There was a problem hiding this comment.
Pull request overview
Bumps the github.com/Azure/ARO-Tools dependency across this repo’s Go workspace tooling modules to pick up the newly added SafeFly pipeline step type, so downstream pipeline generation can represent SafeFly as a first-class step rather than shell-command sniffing.
Changes:
- Update all relevant
tooling/*Go modules to the ARO-Tools pseudo-versionv0.0.0-20260720175808-ca2cea2cb707. - Refresh corresponding
go.sumentries to match the updated ARO-Tools module versions. - Update the
testandmgmt-agentmodules’ ARO-Tools dependencies for consistency across the workspace.
Reviewed changes
Copilot reviewed 9 out of 18 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tooling/yamlwrap/go.mod | Bump ARO-Tools tools/yamlwrap dependency to the new pseudo-version. |
| tooling/yamlwrap/go.sum | Update checksums for the bumped ARO-Tools yamlwrap and testutil deps. |
| tooling/templatize/go.mod | Bump ARO-Tools dependencies (config, pipelines, and related tools) to the new pseudo-version. |
| tooling/templatize/go.sum | Update checksums for all bumped ARO-Tools modules used by templatize. |
| tooling/secret-sync/go.mod | Bump ARO-Tools tools/secret-sync and indirect ARO-Tools deps to the new pseudo-version. |
| tooling/secret-sync/go.sum | Update checksums for bumped ARO-Tools dependencies. |
| tooling/pipeline-documentation/go.mod | Bump ARO-Tools pipelines dependency to the new pseudo-version. |
| tooling/pipeline-documentation/go.sum | Update checksums for bumped ARO-Tools pipelines. |
| tooling/helmtest/go.mod | Bump ARO-Tools config, pipelines, and testutil deps to the new pseudo-version. |
| tooling/helmtest/go.sum | Update checksums for bumped ARO-Tools dependencies. |
| tooling/hcpctl/go.mod | Bump ARO-Tools tools/cmdutils dependency to the new pseudo-version. |
| tooling/hcpctl/go.sum | Update checksums for bumped ARO-Tools cmdutils. |
| tooling/grafanactl/go.mod | Bump ARO-Tools tools/grafanactl and indirect cmdutils to the new pseudo-version. |
| tooling/grafanactl/go.sum | Update checksums for bumped ARO-Tools dependencies. |
| test/go.mod | Bump ARO-Tools config and prow-job-executor (and indirect tool deps) to the new pseudo-version. |
| test/go.sum | Update checksums for bumped ARO-Tools dependencies used by test. |
| mgmt-agent/go.mod | Bump ARO-Tools testutil dependency to the new pseudo-version. |
| mgmt-agent/go.sum | Update checksums for bumped ARO-Tools testutil. |
|
/retest |
978675f to
47739c8
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Mustafa-Ali-code The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Mustafa-Ali-code
changed the title
| case *types.SafeFlyStep: | ||
| logger.Info("SafeFly submission requires a live EV2 rollout, skipping in templatize", "step", step.StepName()) | ||
| return nil, nil, nil |
|
@Mustafa-Ali-code: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What
Add an explicit SafeFlyStep case that logs and skips instead of the generic default. And add a SafeFly case so shellIdentity config references are checked
Why
SafeFly submission needs a live EV2 rollout, so templatize can't run it, so skipping at runtime. No accompanying Aro-Tools bump since the actual step bump landed on this PR #6201
Testing
go build and go test pass in tooling/templatize
PR Checklist
If E2E tests are included:
demonstrate that the test is able to detect a defect/error and fail with
proper error message and logs which communicates nature of the problem.