feat: add barretenberg-rs crate publishing infrastructure #19801
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add crate metadata to Cargo.toml (description, license, repository, etc.) - Add README.md with usage examples - Add GitHub Actions workflow for building static libraries for all targets
Collaborator
|
I'm not a fan of the separate workflow, this is something we should overall delete for the bb publish packages (if you could maybe bundle it here) as it is obsolete It should just be part of the bootstrap release path, testable by putting ci-release-pr label on this pr. We will want to build all those targets in normal cpp bootstrap |
- Remove separate publish-barretenberg-rs.yml workflow - Add iOS toolchains (aarch64-ios.cmake, aarch64-ios-sim.cmake) - Add Android toolchains (aarch64-android.cmake, x86_64-android.cmake) - Add CMake presets for ios-arm64, ios-sim-arm64, android-arm64, android-x86_64 - Add build_ios and build_android functions to bootstrap.sh - Update build_release_dir to package libbb-external.a for FFI backend Mobile static libraries will be included in releases for barretenberg-rs FFI backend.
Contributor
Author
|
Cross-building to iOS requires Xcode SDK which is only available on macOS. My laptop in the office is too old and slow to build stuff but I can try tomorrow at home. To run it on CI, we might need macOS machines on AWS. @charlielye @ludamad Do we have access to macOS machines? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
publish-barretenberg-rs.yml) for building static librariesWorkflow Details
The workflow builds
libbb-external.afor all supported targets:Triggered manually with version input. Creates GitHub release with pre-built libraries.
Related
Test plan