fix: make CaptureManager.stop() idempotent during drain#98
Open
terbin wants to merge 1 commit into
Open
Conversation
stop() guarded only on !capturing, but the StorageFlow drain runs for up to a minute on big captures with capturing still true. Re-entries in that window (stale button clicks, onClientDisconnect on reconnect) re-emitted the whole HotCache and spammed "Stopping capture..." chat. Add a stopping sentinel reset by the drain's cleanup block.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
stop() guarded only on !capturing, but the StorageFlow drain runs for up to a minute on big captures with capturing still true. Re-entries in that window (stale button clicks, onClientDisconnect on reconnect) re-emitted the whole HotCache and spammed "Stopping capture..." chat. Add a stopping sentinel reset by the drain's cleanup block.
Verification
No double-stop and no "Stopping capture..." chat spam on disconnect-during-drain (verified by triggering disconnect while a multi-second drain was in flight).