feat: preserve PersistenceRequired and add forceMobPersistence#105
Open
terbin wants to merge 1 commit into
Open
feat: preserve PersistenceRequired and add forceMobPersistence#105terbin wants to merge 1 commit into
terbin wants to merge 1 commit into
Conversation
Vanilla persistence semantics state that a mob with a custom name should survive chunk unload (PersistenceRequired = true on the NBT). Captures were emitting these mobs without the flag, so loading a captured world and walking out of view caused the mob to despawn, which players reasonably treated as a capture bug. Always set PersistenceRequired on name-tagged mobs at capture time, matching vanilla expectations. Expose forceMobPersistence (default off) for users who want the same guarantee extended to every captured mob, at the cost of vanilla despawn behaviour across the whole capture.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vanilla persistence semantics state that a mob with a custom name should survive chunk unload (PersistenceRequired = true on the NBT). Captures were emitting these mobs without the flag, so loading a captured world and walking out of view caused the mob to despawn, which players reasonably treated as a capture bug.
Always set PersistenceRequired on name-tagged mobs at capture time, matching vanilla expectations. Expose forceMobPersistence (default off) for users who want the same guarantee extended to every captured mob, at the cost of vanilla despawn behaviour across the whole capture.
Verification
26 / 26 name-tagged entities in server capture capture have
PersistenceRequired = 1after the fix.Note
Adds a config flag and one lang key in en_us.