Fix Learning Mode admin CSS path for Divi theme#8034
Open
thisismyurl wants to merge 1 commit into
Open
Conversation
The admin editor enqueue pointed at css/3rd-party/themes/div/learning-mode.css (missing the 'i'), so the Learning Mode stylesheet failed to load in the lesson and site editors for the Divi theme. The front-end enqueue and the editor stylesheet already use the correct 'divi/' directory. Closes Automattic#7863
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7863.
The Learning Mode admin stylesheet for the Divi theme was enqueued from
css/3rd-party/themes/div/learning-mode.css— a directory that doesn't exist (theiis missing), so Learning Mode styles fail to load in the lesson editor and site editor with Divi active. The front-end enqueue and the Divi editor stylesheet already use the correctdivi/directory, which is why only the admin editor view was affected.Fix
One-character path correction:
div/→divi/insensei_admin_load_learning_mode_style_for_divi_theme().Testing
The change only corrects an asset path (no unit-testable state). Verified
css/3rd-party/themes/divi/learning-mode.cssis the path the front-end enqueue and the Divi editor stylesheet already reference, and that no otherdiv/reference remains.Changelog entry added (Significance: patch, Type: fixed).
Props @thisismyurl.
(full disclosure: AI helped me identify the issue and verify my work)