Migrate learner management start date to progress repositories by donnapep · Pull Request #7933 · Automattic/sensei

donnapep · 2026-04-01T18:44:44Z

Summary

Adds set_started_at() to course and lesson progress model interfaces/abstracts (follows existing set_updated_at() pattern)
Migrates the Students AJAX handler (edit_date_started) from get/update_comment_meta to progress repository get()/set_started_at()/save()
Migrates the Students list table start date display from get_comment_meta to repository lookup

Test plan

HPPS disabled (comments storage)

Go to Sensei LMS → Settings → Experimental Features
Uncheck "High-Performance Progress Storage" and save
Navigate to Sensei LMS → Students (the top-level menu item)
In the students list, find a student enrolled in a course and click the course name in their row
Verify the Date Started column displays correctly
Click the date to edit it, change it, and save — verify the new date persists after page reload
Click the Lessons tab, then Manage students on a lesson
Verify the lesson's Date Started column displays correctly
Click the date to edit it, change it, and save — verify the new date persists after page reload

HPPS enabled (tables storage)

Go to Sensei LMS → Settings → Experimental Features
Check "High-Performance Progress Storage"
Select "High-Performance progress storage (experimental)" for the repository option and save
Navigate to Sensei LMS → Students, find a student and click the course name in their row
Verify the Date Started column displays correctly
Click the date to edit it, change it, and save — verify the new date persists after page reload
Click the Lessons tab, then Manage students on a lesson
Verify the lesson's Date Started column displays correctly
Click the date to edit it, change it, and save — verify the new date persists after page reload

Sync check

If sync is enabled: after editing a date in tables mode, switch back to comments mode (uncheck HPPS) and verify the edited date carried over

🤖 Generated with Claude Code

Copilot

Pull request overview

This PR migrates Learner Management “start date” read/edit functionality away from direct comment meta access and into the internal student progress repositories, adding a set_started_at() API to course/lesson progress models to support that change across storage backends (comments vs HPPS tables).

Changes:

Add set_started_at() to course + lesson progress interfaces/abstracts (mirroring the existing set_updated_at() pattern) and add unit tests for it.
Update the Learner Management AJAX handler (edit_date_started) to update started_at via the appropriate progress repository and persist via save().
Update the Learners list table “start date” display to read from the progress repository rather than get_comment_meta().

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
tests/unit-tests/internal/student-progress/lesson-progress/models/test-class-tables-based-lesson-progress.php	Adds unit coverage for `set_started_at()` on tables-based lesson progress.
tests/unit-tests/internal/student-progress/lesson-progress/models/test-class-comments-based-lesson-progress.php	Adds unit coverage for `set_started_at()` on comments-based lesson progress.
tests/unit-tests/internal/student-progress/course-progress/models/test-class-tables-based-course-progress.php	Adds unit coverage for `set_started_at()` on tables-based course progress.
tests/unit-tests/internal/student-progress/course-progress/models/test-class-comments-based-course-progress.php	Adds unit coverage for `set_started_at()` on comments-based course progress.
includes/internal/student-progress/lesson-progress/models/class-lesson-progress-interface.php	Introduces `set_started_at()` to the lesson progress model contract.
includes/internal/student-progress/lesson-progress/models/class-lesson-progress-abstract.php	Implements `set_started_at()` in the shared lesson progress base class.
includes/internal/student-progress/course-progress/models/class-course-progress-interface.php	Introduces `set_started_at()` to the course progress model contract.
includes/internal/student-progress/course-progress/models/class-course-progress-abstract.php	Implements `set_started_at()` in the shared course progress base class.
includes/admin/class-sensei-learners-main.php	Reads `started_at` via progress repositories for display in Learner Management rows.
includes/admin/class-sensei-learner-management.php	Writes `started_at` via progress repositories in the `edit_date_started` AJAX endpoint.
changelog/add-hpps-learner-management-start-date	Changelog entry for the migration to repository-based start date handling.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Add set_started_at() to course and lesson progress model interfaces and abstract classes. Migrate edit_date_started() in learner management and the start date display in learners-main to use progress repositories instead of direct comment meta access. Update the sensei_learners_learner_updated filter to pass user_id instead of comment_id. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

- Convert date to UTC before set_started_at() for tables-based storage - Compute $updated from old vs new started_at comparison - Preserve hook backward compat: keep deprecated comment_id param (0), add user_id as 4th - Use absint() instead of sanitize_key() for user_id - Use wp_date() with wp_timezone() for start date display - Fix equals sign alignment in learners-main Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

- Split course/lesson repo branches to avoid union type on save() - Guard $post_id against false before passing to repo get() - Cast wp_date() return to string to satisfy esc_attr() type Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

…ment The filter's $comment_id parameter is a storage implementation detail that no longer applies across both storage backends. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

github-actions · 2026-06-18T19:38:27Z

WordPress Playground Preview

The changes in this pull request can previewed and tested using a WordPress Playground instance.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Convert exit() to wp_die() in edit_date_started so the AJAX handler is catchable in tests, and move set_started_at()/save() after the no-op guard to avoid a redundant write when the date is unchanged. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Revert untested guard clauses to exit() so Psalm keeps type narrowing (wp_die() is not stubbed as noreturn), keeping wp_die() only on the tested no-op and success paths, and suppress the correlated-union warning on the repository save. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Copilot

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.

…row_updated Add sensei_students_row_updated, passing user_id and post_type so listeners work under both comments and tables storage, and honor its return value. Keep firing the deprecated sensei_learners_learner_updated for back compat, pointing it at the new hook. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

… docs - Use absint( wp_unslash() ) for post_id instead of sanitize_key() - Assert saved start date via wp_date() in site timezone so the test is stable under HPPS/tables storage and non-UTC timezones - Correct the invoke helper docblock: only the tested paths wp_die(); validation paths use exit Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

donnapep · 2026-06-19T20:04:13Z

@merkushin Got this PR ready before I head out for some AFK. This one pairs with https://github.com/Automattic/sensei-pro/pull/2695. I've given you read-only access to Sensei Pro. 🙌🏻

merkushin · 2026-06-19T20:34:22Z

@donnapep Haha, I got the invitation, but not a notification about this mention 😅 (Perhaps I choked my notifications from GitHub too much.) And I encountered the comment because I was investigating where sensei_students_row_updated was added :)
I'm skimming them briefly now, but will check more thoroughly on the weekend.

merkushin

Looks good and works as described in the test instructions.

I noticed a coulple of potential visual bugs, not related to the PR.

The bubble is missing the blue background. In fact, it was more trickier — it sometimes appeared, sometimes disappeared on hovering the main menu, etc.

Initially, I blamed the assets, but I checked assets were built, and generally styles looked good.

The spacing on the left looks weird.
Again, I hope it was just the issue of my setup…

merkushin · 2026-06-21T13:42:00Z

+			$post_id = absint( wp_unslash( $_POST['data']['post_id'] ) );
 		} else {
-			exit( '' );
+			exit;


Every time I see these exits, I'm crying 🥲

merkushin · 2026-06-21T13:54:15Z

+		$repository = 'course' === $post_type
+			? Sensei()->course_progress_repository_factory->create()
+			: Sensei()->lesson_progress_repository_factory->create();


A tiny possible improvement here could be to hide this logic behind a factory method like:

$repository = Sensei()->create_progress_repository( $post_type );

merkushin · 2026-06-21T13:57:48Z

+					$progress_repository = 'course' === $post_type
+						? Sensei()->course_progress_repository_factory->create()
+						: Sensei()->lesson_progress_repository_factory->create();


No surprise, that factory method could be used here as well.
Perhaps, there are (or will be) even more places for it.

Copilot AI review requested due to automatic review settings April 1, 2026 18:44

Copilot started reviewing on behalf of donnapep April 1, 2026 18:45 View session

Copilot AI reviewed Apr 1, 2026

View reviewed changes

donnapep force-pushed the add/hpps-learner-start-date-pr branch from c9d3191 to fe5abad Compare April 1, 2026 19:06

donnapep added this to the 4.26.0 milestone Apr 1, 2026

donnapep self-assigned this Apr 1, 2026

donnapep added the HPPS label Apr 1, 2026

donnapep and others added 4 commits April 1, 2026 15:20

fix: add missing docblocks to progress model test methods

dbf1ade

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

donnapep force-pushed the add/hpps-learner-start-date-pr branch from 04aadef to fc51a1f Compare April 1, 2026 19:22

donnapep mentioned this pull request Apr 8, 2026

Make sensei_check_for_activity() HPPS-aware #7941

Open

4 tasks

fix: deprecate sensei_learners_learner_updated filter with no replace…

0d5fda1

…ment The filter's $comment_id parameter is a storage implementation detail that no longer applies across both storage backends. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

donnapep modified the milestones: 4.26.0, 4.26.1 Jun 8, 2026

Merge branch 'trunk' into add/hpps-learner-start-date-pr

ee4e923

donnapep added this to the 4.26.2 milestone Jun 18, 2026

donnapep and others added 9 commits June 19, 2026 10:17

Rename changelog: avoid outdated 'learner management' term

c93921d

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Collapse duplicate progress repository get() call

761bc7b

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Rename start date vars to student; drop redundant wp_timezone arg

c1d0987

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Collapse duplicate progress repository save logic in edit_date_started

b467a7e

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Restore no-op guard when start date is unchanged

7a71c5d

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Remove useless test cases

9edf462

Merge branch 'trunk' into add/hpps-learner-start-date-pr

90150b8

donnapep requested a review from Copilot June 19, 2026 18:23

Copilot started reviewing on behalf of donnapep June 19, 2026 18:23 View session

Copilot AI reviewed Jun 19, 2026

View reviewed changes

Comment thread tests/unit-tests/admin/test-class-sensei-learner-management.php Outdated

Comment thread tests/unit-tests/admin/test-class-sensei-learner-management.php Outdated

Comment thread includes/admin/class-sensei-learner-management.php

donnapep and others added 2 commits June 19, 2026 15:13

donnapep added the Deprecation This change introduces a deprecation. label Jun 19, 2026

merkushin approved these changes Jun 21, 2026

View reviewed changes

Uh oh!

Conversation

donnapep commented Apr 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Related

Test plan

HPPS disabled (comments storage)

HPPS enabled (tables storage)

Sync check

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Jun 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

WordPress Playground Preview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

donnapep commented Jun 19, 2026

Uh oh!

merkushin commented Jun 19, 2026

Uh oh!

merkushin left a comment

Choose a reason for hiding this comment

Uh oh!

merkushin Jun 21, 2026

Choose a reason for hiding this comment

Uh oh!

merkushin Jun 21, 2026

Choose a reason for hiding this comment

Uh oh!

merkushin Jun 21, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

donnapep commented Apr 1, 2026 •

edited

Loading

github-actions Bot commented Jun 18, 2026 •

edited

Loading