Preserve SaaS card text wrapper geometry#535
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
core/groupwrappers instead of flattening them into paragraphs when their classes carry visual geometry semantics like badges, tags, prices, results, labels, names, and captions.max-widththrough the existing dimensions support mapper/serializer alongsidemin-height.Root cause
SaaS sections and cards kept their outer grid/card classes, but text-only inner wrappers such as
.tag,.tier-name,.tier-price,.use-case-result, and.featured-badgewere flattened into paragraph/text shapes. The source CSS targets those wrapper classes for display, gap, padding, border radius, and card label geometry, so the transformed DOM lost selector addressability and produced highrestyle_geometry/position_offsetsymptoms. Inlinemax-widthwas also not mapped through dimensions support, so section/card width constraints could be dropped when not class-owned.Metrics
Static parity from
php tools/static-parity/run.php --fixture <fixture> --top 1:15-saasscore15-saasprop-par15-saascoverage15-saasfindings2-onepager-coffeescore3-artist-musicscore31-personal-cv-academicscoreTests
php tests/unit/block-style-support-conversion.phpphp tests/contract/run.phpphp tests/parity/run.phpphp tools/static-parity/run.php --fixture 15-saas --top 1php tools/static-parity/run.php --fixture 2-onepager-coffee --top 1php tools/static-parity/run.php --fixture 3-artist-music --top 1php tools/static-parity/run.php --fixture 31-personal-cv-academic --top 1Remaining SaaS Geometry Map
AI assistance