Skip to content

Extract button signal classifier#534

Merged
chubes4 merged 1 commit into
trunkfrom
refactor/php-button-width-resolver
Jul 6, 2026
Merged

Extract button signal classifier#534
chubes4 merged 1 commit into
trunkfrom
refactor/php-button-width-resolver

Conversation

@chubes4

@chubes4 chubes4 commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Extract button promotion heuristics from ButtonsPattern into ButtonSignalClassifier
  • Reuse the class/id signal helper in ButtonMenuVisualProbe so transform and probe signal vocabulary share one implementation point
  • Add unit coverage for role, class/id, CTA/action, action text, inline style, plain-link, and transform promotion behavior

Testing

  • composer run test:unit
  • composer test

AI assistance

  • AI assistance: Yes
  • Tool(s): openai/gpt-5.5 via OpenCode
  • Used for: Refactor implementation, test coverage, verification, and PR preparation

@chubes4 chubes4 force-pushed the refactor/php-button-width-resolver branch from 6af7cfd to 2359a33 Compare July 6, 2026 20:50
@chubes4 chubes4 merged commit 41ec511 into trunk Jul 6, 2026
1 check passed
@chubes4 chubes4 deleted the refactor/php-button-width-resolver branch July 6, 2026 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant