Skip to content

Extract fallback finding normalization#526

Merged
chubes4 merged 1 commit into
trunkfrom
refactor/php-transformer-diagnostics-helper
Jul 6, 2026
Merged

Extract fallback finding normalization#526
chubes4 merged 1 commit into
trunkfrom
refactor/php-transformer-diagnostics-helper

Conversation

@chubes4

@chubes4 chubes4 commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Extract fallback generic metadata enrichment from FallbackDiagnostic into FallbackFindingNormalizer.
  • Keep FallbackDiagnostic focused on diagnostic-code default payloads while preserving the existing public build/withGenericFindingMetadata API.
  • Add focused unit coverage for unsupported-element family normalization, selector specificity projection, ancestry reasons, and inline semantic runtime-island classification.

Testing

  • composer test

AI assistance

  • AI assistance: Yes
  • Tool(s): OpenAI GPT-5.5 via OpenCode
  • Used for: Inspected the PHP transformer diagnostics flow, implemented the behavior-preserving extraction, added focused unit coverage, ran tests, and prepared this PR.

@chubes4 chubes4 merged commit be3575d into trunk Jul 6, 2026
1 check passed
@chubes4 chubes4 deleted the refactor/php-transformer-diagnostics-helper branch July 6, 2026 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant