Custom Event Refactor [AARD-2080]#1275
Merged
BrandonPacewic merged 15 commits intodevfrom Apr 3, 2026
Merged
Conversation
rutmanz
requested review from
BrandonPacewic,
Dhruv-0-Arora,
PepperLola and
azaleacolburn
Member
Author
|
(because other open PRs add new events in ways that won't necessarily show up as conflicts, I'll want to do one last check before this is merged) |
5 tasks
azaleacolburn
requested changes
Aug 19, 2025
azaleacolburn
approved these changes
Aug 20, 2025
BrandonPacewic
requested changes
Aug 29, 2025
Member
BrandonPacewic
left a comment
BrandonPacewic
left a comment
There was a problem hiding this comment.
There are some non-trival conflicts here. Since this is not user facing this will not be put in for v7.2.
Member
Author
|
Just merged |
* dev: (44 commits) fix: don't add new zone to array before navigating to config fix: revert `fission/src/util/TypeConversions.ts` formatting fix: biome fmt issues fix: build isuses fix: correct zone refactor regressions fix: biome lint warnings feat: import unstable mira files with warnings revert: `2fd4c67aae0be43b473ed0e5b5f2d90f17ecfcf6` feat: handle zero triangles in `createConcaveShapeSettingsFromPart` doc: add current status to in development features docs: update manual exporter install tutorial docs: tutorial content updates fix: spelling, grammer, and formatting corrections Update tutorials/CommandPalette.md Update tutorials/SpawnAsset.md Update tutorials/SpawnAsset.md Update tutorials/Multiplayer.md Update tutorials/MatchMode.md Update tutorials/MatchMode.md Update tutorials/MatchMode.md ...
BrandonPacewic
approved these changes
Apr 3, 2026
Member
BrandonPacewic
left a comment
BrandonPacewic
left a comment
There was a problem hiding this comment.
I went through and double checked changes to events made pre and post this PR. I believe we should be good to go. If anything else comes up I'll open another PR.
Thanks for doing this. Love me a good refactor!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task
AARD-2080
Symptom
Currently there are a bunch of custom event classes with inconsistent implementations that both make it harder to find events and make the whole system more verbose. Unsubscription is also often done incorrectly or not done at all
Solution
I introduced an
EventSystemclass that manages all custom events and has genericcreate,dispatch, andlistenmethods.Verification
Go through and try and trigger the list of events found in
EventDataMapand confirm that they still work as before. This PR should not affect functionalityBefore merging, ensure the following criteria are met: