Regarding autora issue #707 (https://github.com/AutoResearch/autora/i…#8
Open
LJKS wants to merge 1 commit into
Open
Regarding autora issue #707 (https://github.com/AutoResearch/autora/i…#8LJKS wants to merge 1 commit into
LJKS wants to merge 1 commit into
Conversation
Old behaviour of check_firebase_status uses the argument 'timeout', but does not implement any functionality with it (confirm e.g. by simply ctrl+f time_out, its only listed in the documentation). This behaviour is confusing for users, and causes failed experiments, when users actually timeout (blocking the experiment cycle, as one slot is permanently blocked and not continuing the experiment runner). The proposed fix only changes one line (__init__.py, line 371). Confidence in the solution is low - I do not have much experience with firebase. However to my best understanding of the given code, and the experiments I have been running using this fix today, the proposed fix solves the issue at hand.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regarding autora issue #707 (AutoResearch/autora#707)
Old behaviour of check_firebase_status uses the argument 'timeout', but does not implement any functionality with it (confirm e.g. by simply ctrl+f time_out, its only listed in the documentation).
This behaviour is confusing for users, and causes failed experiments, when users actually timeout (blocking the experiment cycle, as one slot is permanently blocked and not continuing the experiment runner).
The proposed fix only changes one line (init.py, line 371). Confidence in the solution is low - I do not have much experience with firebase. However to my best understanding of the given code, and the experiments I have been running using this fix today, the proposed fix solves the issue at hand.