showlinux: replace memcpy concat to GNU/Linux standard stpcpy() #356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Atoptool, hi again.
make_proc_dynamicgen() function uses memcpy() instead of strcat() to concatenate strings. This avoids calculating the length of the string multiple times.
Also, for a more simplified readable code and compliance with the standardization of GNU/Linux code, I think the new changes will be easier to maintain in the future.
I checked that total size string (about 167 bytes) does not exceed the buffer size (format, 300 bytes), so overflow is excluded. stpcpy() processes the terminating null character correctly, and the resulting string is formed correctly.
Documentation: https://linux.die.net/man/3/stpcpy