resolver: support package exports for root import (".") #2971
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add basic support for the "exports" field in package.json when resolving
bare package imports. Checks "exports["."]" first, then falls back to
existing ascMain and assembly/ behavior.
This enables modern package setups while preserving full compatibility.
Tested with --traceResolution on packages using "exports": { ".": ... }
HerrCai0907
reviewed
Dec 30, 2025
Member
HerrCai0907
left a comment
HerrCai0907
left a comment
There was a problem hiding this comment.
I like this concept.
However, could it be possible to limit it under cli/index.js part? I think all module resolving logic is out of src scope.
As requested — keep core src/ logic unchanged, handle modern exports only in CLI package loading path.
Author
|
@HerrCai0907 Thank you for the feedback! I've moved all the package resolution logic to the CLI side only, keeping the core parser unchanged. The module resolving now happens exclusively in index.js during file loading |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes or improves upon long-standing bare import limitations.
Allows libraries like @whatever/stuff to use standard "exports" mapping.
No breaking changes — full fallback to ascMain/assembly.