Skip to content

v1.0.1 public release#262

Merged
rebelinux merged 28 commits into
masterfrom
dev
Jun 22, 2026
Merged

v1.0.1 public release#262
rebelinux merged 28 commits into
masterfrom
dev

Conversation

@rebelinux

Copy link
Copy Markdown
Collaborator

[1.0.1] - 2026-06-22

Added

  • Add cmdlet Get-AbrAdLog to collect report diagnostic log

Changed

  • Bump module version to 1.0.1
  • Upgrade AsBuiltReport.Diagram module to version 1.0.8
  • Upgrade AsBuiltReport.Chart module to version 0.3.3
  • Set an option to enable/disable the main logo of the diagrams
  • Update github actions to latest releases

Fixed

  • Add validation for ADSystem before accessing RootDomain to prevent errors
  • Add success message logging for completed commands in Invoke-CommandWithTimeout function
  • Update localization files to include NoData messages and improve key matching in tests
  • Fix 255
  • Fix: remove non-printable ASCII characters from a string

rebelinux and others added 28 commits May 12, 2026 20:39
@github-actions

Copy link
Copy Markdown

PSScriptAnalyzer results:

Errors: [0], Warnings: [33], Information: [3]


RuleName   : PSReviewUnusedParameter
Severity   : Warning
ScriptName : Invoke-AsBuiltReport.Microsoft.AD.ps1
Line       : 22
Message    : The parameter 'Credential' has been declared but not used.

RuleName   : PSReviewUnusedParameter
Severity   : Warning
ScriptName : Get-AbrADAuthenticationPolicy.ps1
Line       : 20
Message    : The parameter 'ValidDcFromDomain' has been declared but not used.

RuleName   : PSReviewUnusedParameter
Severity   : Warning
ScriptName : Get-AbrADTrust.ps1
Line       : 20
Message    : The parameter 'ValidDCFromDomain' has been declared but not used.

RuleName   : PSReviewUnusedParameter
Severity   : Warning
ScriptName : Get-AbrADDomain.ps1
Line       : 20
Message    : The parameter 'ValidDcFromDomain' has been declared but not used.

RuleName   : PSReviewUnusedParameter
Severity   : Warning
ScriptName : Get-AbrADDFSHealth.ps1
Line       : 20
Message    : The parameter 'DCs' has been declared but not used.

RuleName   : PSReviewUnusedParameter
Severity   : Warning
ScriptName : Get-AbrADOU.ps1
Line       : 20
Message    : The parameter 'ValidDCFromDomain' has been declared but not used.

RuleName   : PSUseConsistentWhitespace
Severity   : Warning
ScriptName : Get-AbrADSite.ps1
Line       : 225
Message    : Use space before open brace.

RuleName   : PSReviewUnusedParameter
Severity   : Warning
ScriptName : Get-AbrADKerberosAudit.ps1
Line       : 20
Message    : The parameter 'ValidDCFromDomain' has been declared but not used.

RuleName   : PSReviewUnusedParameter
Severity   : Warning
ScriptName : Get-AbrADGPO.ps1
Line       : 20
Message    : The parameter 'ValidDCFromDomain' has been declared but not used.

RuleName   : PSReviewUnusedParameter
Severity   : Warning
ScriptName : Get-AbrADDomainObject.ps1
Line       : 19
Message    : The parameter 'ValidDcFromDomain' has been declared but not used.

RuleName   : PSReviewUnusedParameter
Severity   : Warning
ScriptName : Get-ADObjectSearch.ps1
Line       : 22
Message    : The parameter 'Filter' has been declared but not used.

RuleName   : PSReviewUnusedParameter
Severity   : Warning
ScriptName : Get-ADObjectSearch.ps1
Line       : 23
Message    : The parameter 'Properties' has been declared but not used.

RuleName   : PSReviewUnusedParameter
Severity   : Warning
ScriptName : Get-ADObjectSearch.ps1
Line       : 24
Message    : The parameter 'SelectPrty' has been declared but not used.

RuleName   : PSReviewUnusedParameter
Severity   : Warning
ScriptName : ConvertTo-ADObjectName.ps1
Line       : 22
Message    : The parameter 'DC' has been declared but not used.

RuleName   : PSReviewUnusedParameter
Severity   : Warning
ScriptName : ConvertTo-ADCanonicalName.ps1
Line       : 21
Message    : The parameter 'Domain' has been declared but not used.

RuleName   : PSAvoidUsingPlainTextForPassword
Severity   : Warning
ScriptName : Start-AsBuiltReportMSAD.ps1
Line       : 103
Message    : Parameter '$PasswordTextBox' should not use String type but either 
             SecureString or PSCredential, otherwise it increases the chance to 
             expose this sensitive information.

RuleName   : PSUseBOMForUnicodeEncodedFile
Severity   : Warning
ScriptName : Start-AsBuiltReportMSAD.ps1
Line       : 
Message    : Missing BOM encoding for non-ASCII encoded file 
             'Start-AsBuiltReportMSAD.ps1'

RuleName   : PSUseBOMForUnicodeEncodedFile
Severity   : Warning
ScriptName : Get-AbrDiagReplication.ps1
Line       : 
Message    : Missing BOM encoding for non-ASCII encoded file 
             'Get-AbrDiagReplication.ps1'

RuleName   : PSUseBOMForUnicodeEncodedFile
Severity   : Warning
ScriptName : MicrosoftAD.psd1
Line       : 
Message    : Missing BOM encoding for non-ASCII encoded file 'MicrosoftAD.psd1'

RuleName   : PSUseDeclaredVarsMoreThanAssignments
Severity   : Warning
ScriptName : LocalizationData.Tests.ps1
Line       : 3
Message    : The variable 'LanguagePath' is assigned but never used.

RuleName   : PSUseDeclaredVarsMoreThanAssignments
Severity   : Warning
ScriptName : LocalizationData.Tests.ps1
Line       : 35
Message    : The variable 'TemplateKeys' is assigned but never used.

RuleName   : PSUseDeclaredVarsMoreThanAssignments
Severity   : Warning
ScriptName : LocalizationData.Tests.ps1
Line       : 36
Message    : The variable 'LanguageFolders' is assigned but never used.

RuleName   : PSUseSingularNouns
Severity   : Warning
ScriptName : LocalizationData.Tests.ps1
Line       : 6
Message    : The cmdlet 'Get-NestedLocalizationKeys' uses a plural noun. A 
             singular noun should be used instead.

RuleName   : PSUseDeclaredVarsMoreThanAssignments
Severity   : Warning
ScriptName : AsBuiltReport.Microsoft.AD.Tests.ps1
Line       : 18
Message    : The variable 'Manifest' is assigned but never used.

RuleName   : PSUseDeclaredVarsMoreThanAssignments
Severity   : Warning
ScriptName : AsBuiltReport.Microsoft.AD.Tests.ps1
Line       : 191
Message    : The variable 'InvokeCommand' is assigned but never used.

RuleName   : PSUseDeclaredVarsMoreThanAssignments
Severity   : Warning
ScriptName : AsBuiltReport.Microsoft.AD.Tests.ps1
Line       : 234
Message    : The variable 'JsonConfig' is assigned but never used.

RuleName   : PSUseDeclaredVarsMoreThanAssignments
Severity   : Warning
ScriptName : AsBuiltReport.Microsoft.AD.Tests.ps1
Line       : 289
Message    : The variable 'JsonConfig' is assigned but never used.

RuleName   : PSUseDeclaredVarsMoreThanAssignments
Severity   : Warning
ScriptName : AsBuiltReport.Microsoft.AD.Tests.ps1
Line       : 403
Message    : The variable 'PublicFunctions' is assigned but never used.

RuleName   : PSUseDeclaredVarsMoreThanAssignments
Severity   : Warning
ScriptName : AsBuiltReport.Microsoft.AD.Tests.ps1
Line       : 404
Message    : The variable 'PrivateFunctions' is assigned but never used.

RuleName   : PSUseDeclaredVarsMoreThanAssignments
Severity   : Warning
ScriptName : AsBuiltReport.Microsoft.AD.Tests.ps1
Line       : 434
Message    : The variable 'ModuleRoot' is assigned but never used.

RuleName   : PSUseDeclaredVarsMoreThanAssignments
Severity   : Warning
ScriptName : AsBuiltReport.Microsoft.AD.Tests.ps1
Line       : 435
Message    : The variable 'SettingsPath' is assigned but never used.

RuleName   : PSUseDeclaredVarsMoreThanAssignments
Severity   : Warning
ScriptName : AsBuiltReport.Microsoft.AD.Tests.ps1
Line       : 471
Message    : The variable 'PublicFunctions' is assigned but never used.

RuleName   : PSUseDeclaredVarsMoreThanAssignments
Severity   : Warning
ScriptName : AsBuiltReport.Microsoft.AD.Tests.ps1
Line       : 553
Message    : The variable 'InvokeCommand' is assigned but never used.

RuleName   : PSUseOutputTypeCorrectly
Severity   : Information
ScriptName : Get-ADObjectSearch.ps1
Line       : 31
Message    : The cmdlet 'Get-ADObjectSearch' returns an object of type 
             'System.Collections.Generic.List`1[[System.Object, 
             System.Private.CoreLib, Version=9.0.0.0, Culture=neutral, 
             PublicKeyToken=7cec85d7bea7798e]]' but this type is not declared 
             in the OutputType attribute.

RuleName   : PSUseOutputTypeCorrectly
Severity   : Information
ScriptName : ConvertTo-ADObjectName.ps1
Line       : 28
Message    : The cmdlet 'ConvertTo-ADObjectName' returns an object of type 
             'System.Collections.Generic.List`1[[System.Object, 
             System.Private.CoreLib, Version=9.0.0.0, Culture=neutral, 
             PublicKeyToken=7cec85d7bea7798e]]' but this type is not declared 
             in the OutputType attribute.

RuleName   : PSUseOutputTypeCorrectly
Severity   : Information
ScriptName : ConvertTo-ADCanonicalName.ps1
Line       : 29
Message    : The cmdlet 'ConvertTo-ADCanonicalName' returns an object of type 
             'System.Collections.Generic.List`1[[System.Object, 
             System.Private.CoreLib, Version=9.0.0.0, Culture=neutral, 
             PublicKeyToken=7cec85d7bea7798e]]' but this type is not declared 
             in the OutputType attribute.

@rebelinux rebelinux merged commit f4f644e into master Jun 22, 2026
2 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant