Skip to content

insert operations with common properties#2871

Open
ArnoldSmith86 wants to merge 2 commits into
mainfrom
fix/2552-editor-prefills-routine-parameters
Open

insert operations with common properties#2871
ArnoldSmith86 wants to merge 2 commits into
mainfrom
fix/2552-editor-prefills-routine-parameters

Conversation

@ArnoldSmith86
Copy link
Copy Markdown
Owner

@ArnoldSmith86 ArnoldSmith86 commented Feb 7, 2026

Fixes #2552. The list of common parameters should probably be reviewed..


PR-SERVER-BOT: You can play around with it here: https://test.virtualtabletop.io/PR-2871/pr-test (or any other room on that server)

@ArnoldSmith86 ArnoldSmith86 added enhancement New feature or request editor This issue/PR involves the JSON Editor labels Feb 7, 2026
@ArnoldSmith86 ArnoldSmith86 force-pushed the fix/2552-editor-prefills-routine-parameters branch from 817d7be to 7acb7e7 Compare February 7, 2026 22:30
@96LawDawg
Copy link
Copy Markdown
Collaborator

This would be a nice PR to add something to the JSON Editor to switch from traditional collections to anonymous collections (adding the square brackets).

@96LawDawg
Copy link
Copy Markdown
Collaborator

It's going to take some time (and negotiation) to come up with the right "grammar" for this. It isn't just which parameters should be included, but also their order. SELECT, for example, should not have "collection" second.

I think the general order should be like this:
Function name
Input collection/widget/source
Mode/Relationship
Miscellaneous parameters specific to the function
Count/value
Output collection/variable/result

Examples (some of these are a little different than what is currently in the PR):

    {
      "func": "SELECT",
      "source": "all",
      "type": "all",
      "property": "parent",
      "value": null,
      "collection": "DEFAULT"
    },
    {
      "func": "GET",
      "collection": "DEFAULT",
      "property": "id",
      "variable": "result"
    },
    {
      "func": "ROTATE",
      "collection": "DEFAULT",
      "mode": "add",
      "angle": 90,
      "count": 1
    },
    {
      "func": "TURN",
      "source": "all",
      "turnCycle": "forward"
    },
    {
      "func": "CLONE",
      "source": "DEFAULT",
      "count": 1,
      "collection": "DEFAULT"
    }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

editor This issue/PR involves the JSON Editor enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Editor Prefills Routine Parameters

2 participants