insert operations with common properties#2871
Open
ArnoldSmith86 wants to merge 2 commits into
Open
Conversation
817d7be to
7acb7e7
Compare
Collaborator
|
This would be a nice PR to add something to the JSON Editor to switch from traditional collections to anonymous collections (adding the square brackets). |
Collaborator
|
It's going to take some time (and negotiation) to come up with the right "grammar" for this. It isn't just which parameters should be included, but also their order. SELECT, for example, should not have "collection" second. I think the general order should be like this: Examples (some of these are a little different than what is currently in the PR): {
"func": "SELECT",
"source": "all",
"type": "all",
"property": "parent",
"value": null,
"collection": "DEFAULT"
},
{
"func": "GET",
"collection": "DEFAULT",
"property": "id",
"variable": "result"
},
{
"func": "ROTATE",
"collection": "DEFAULT",
"mode": "add",
"angle": 90,
"count": 1
},
{
"func": "TURN",
"source": "all",
"turnCycle": "forward"
},
{
"func": "CLONE",
"source": "DEFAULT",
"count": 1,
"collection": "DEFAULT"
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2552. The list of common parameters should probably be reviewed..
PR-SERVER-BOT: You can play around with it here: https://test.virtualtabletop.io/PR-2871/pr-test (or any other room on that server)