Skip to content

Remove class dstName filtering if equals to srcName #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nelimee wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Remove class dstName filtering if equals to srcName #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions src/main/java/net/fabricmc/mappingio/format/enigma/EnigmaWriterBase.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
import net.fabricmc.mappingio.MappingWriter;

abstract class EnigmaWriterBase implements MappingWriter {
EnigmaWriterBase(Writer writer) throws IOException {
EnigmaWriterBase(Writer writer) {
this.writer = writer;
}

Expand Down Expand Up @@ -185,10 +185,8 @@ protected void writeMismatchedOrMissingClasses() throws IOException {
if (dstEnd < 0) dstEnd = dstName.length();
int dstLen = dstEnd - dstStart;

if (dstLen != srcLen || !srcClassName.regionMatches(srcStart, dstName, dstStart, srcLen)) { // src != dst
writer.write(' ');
writer.write(dstName, dstStart, dstLen);
}
writer.write(' ');
writer.write(dstName, dstStart, dstLen);
}
}

Expand Down