Skip to content

fix(markets): invalidate cache on update/pause/resume/cancel (#1273) #1301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Olowodarey merged 1 commit into from
Jul 21, 2026
Merged

fix(markets): invalidate cache on update/pause/resume/cancel (#1273) #1301

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
192 changes: 192 additions & 0 deletions backend/src/markets/markets.service.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import { getRepositoryToken } from '@nestjs/typeorm';
import { DataSource, Repository, SelectQueryBuilder } from 'typeorm';
import { CACHE_MANAGER } from '@nestjs/cache-manager';
import { SorobanService } from '../soroban/soroban.service';
import { CACHE_WARMING_KEYS } from '../cache/cache-warming.keys';

import { User } from '../users/entities/user.entity';
import { UsersService } from '../users/users.service';
Expand Down Expand Up @@ -509,6 +510,7 @@ describe('MarketsService.findFeaturedMarkets', () => {
describe('MarketsService.update', () => {
let service: MarketsService;
let marketsRepository: MockRepo;
let cacheManager: { get: jest.Mock; set: jest.Mock; del: jest.Mock };

const mockCreator = {
id: 'creator-1',
Expand Down Expand Up @@ -598,6 +600,7 @@ describe('MarketsService.update', () => {
}).compile();

service = module.get<MarketsService>(MarketsService);
cacheManager = module.get(CACHE_MANAGER);
});

it('should update market when caller is creator', async () => {
Expand Down Expand Up @@ -681,6 +684,55 @@ describe('MarketsService.update', () => {

expect(result.category).toBe('Sports');
});

it('invalidates trending, active-list, and per-market cache keys on update', async () => {
const market = makeMarket();
const dto: UpdateMarketDto = { title: 'Updated Title' };

marketsRepository.findOne.mockResolvedValue(market);
marketsRepository.save.mockResolvedValue({ ...market, ...dto });

await service.update('market-1', mockCreator.id, dto);

expect(cacheManager.del).toHaveBeenCalledWith(
CACHE_WARMING_KEYS.trendingEvents,
);
expect(cacheManager.del).toHaveBeenCalledWith(
CACHE_WARMING_KEYS.activeEvents,
);
expect(cacheManager.del).toHaveBeenCalledWith(
CACHE_WARMING_KEYS.popularEventDetail('market-1'),
);
});

it('does not invalidate cache when update is rejected', async () => {
const market = makeMarket();
const dto: UpdateMarketDto = { title: 'Updated Title' };

marketsRepository.findOne.mockResolvedValue(market);

await expect(
service.update('market-1', mockOtherUser.id, dto),
).rejects.toThrow(ForbiddenException);
expect(cacheManager.del).not.toHaveBeenCalled();
});

it('stale-read: cache is cleared so a subsequent read reflects the mutation', async () => {
const market = makeMarket();
const dto: UpdateMarketDto = { title: 'Fresh Title' };

// Simulate a stale cached detail entry present before the mutation.
cacheManager.get.mockResolvedValue({ ...market, title: 'Original Title' });

marketsRepository.findOne.mockResolvedValue(market);
marketsRepository.save.mockResolvedValue({ ...market, ...dto });

await service.update('market-1', mockCreator.id, dto);

expect(cacheManager.del).toHaveBeenCalledWith(
CACHE_WARMING_KEYS.popularEventDetail('market-1'),
);
});
});

describe('MarketsService.getPredictionStats', () => {
Expand Down Expand Up @@ -842,6 +894,7 @@ describe('MarketsService.cancelMarket', () => {
let service: MarketsService;
let marketsRepository: MockRepo;
let sorobanService: jest.Mocked<Pick<SorobanService, 'cancelMarket'>>;
let cacheManager: { get: jest.Mock; set: jest.Mock; del: jest.Mock };

const mockCreator = { id: 'creator-1', role: 'user' } as User;
const mockAdmin = { id: 'admin-1', role: 'admin' } as User;
Expand Down Expand Up @@ -890,6 +943,7 @@ describe('MarketsService.cancelMarket', () => {
}).compile();

service = module.get<MarketsService>(MarketsService);
cacheManager = module.get(CACHE_MANAGER);
});

it('throws ForbiddenException when caller is not creator or admin', async () => {
Expand Down Expand Up @@ -945,6 +999,15 @@ describe('MarketsService.cancelMarket', () => {
expect(sorobanService.cancelMarket).toHaveBeenCalledWith('on-chain-1');
expect(marketsRepository.save).toHaveBeenCalled();
expect(result.is_cancelled).toBe(true);
expect(cacheManager.del).toHaveBeenCalledWith(
CACHE_WARMING_KEYS.trendingEvents,
);
expect(cacheManager.del).toHaveBeenCalledWith(
CACHE_WARMING_KEYS.activeEvents,
);
expect(cacheManager.del).toHaveBeenCalledWith(
CACHE_WARMING_KEYS.popularEventDetail('market-1'),
);
});

it('allows admin to cancel any market', async () => {
Expand All @@ -969,3 +1032,132 @@ describe('MarketsService.cancelMarket', () => {
expect(marketsRepository.save).not.toHaveBeenCalled();
});
});

describe('MarketsService pause/resume cache invalidation', () => {
let service: MarketsService;
let marketsRepository: MockRepo;
let sorobanService: jest.Mocked<
Pick<SorobanService, 'pauseMarket' | 'resumeMarket'>
>;
let cacheManager: { get: jest.Mock; set: jest.Mock; del: jest.Mock };

const mockAdmin = { id: 'admin-1', role: 'admin' } as User;

const makeMarket = (overrides: Partial<Market> = {}): Market =>
({
id: 'market-1',
on_chain_market_id: 'on-chain-1',
title: 'Test Market',
end_time: new Date(Date.now() + 60_000),
is_resolved: false,
is_cancelled: false,
is_paused: false,
creator: { id: 'creator-1' } as User,
...overrides,
}) as Market;

beforeEach(async () => {
marketsRepository = {
create: jest.fn(),
save: jest.fn(),
findOne: jest.fn(),
find: jest.fn(),
};

sorobanService = { pauseMarket: jest.fn(), resumeMarket: jest.fn() };

const module: TestingModule = await Test.createTestingModule({
providers: [
MarketsService,
{ provide: getRepositoryToken(Market), useValue: marketsRepository },
{ provide: getRepositoryToken(Comment), useValue: {} },
{ provide: getRepositoryToken(MarketTemplate), useValue: {} },
{ provide: getRepositoryToken(UserBookmark), useValue: {} },
{ provide: getRepositoryToken(Prediction), useValue: {} },
{ provide: UsersService, useValue: {} },
{ provide: SorobanService, useValue: sorobanService },
{ provide: DataSource, useValue: {} },
{ provide: WebhookDispatcherService, useValue: { emit: jest.fn() } },
{
provide: CACHE_MANAGER,
useValue: { get: jest.fn(), set: jest.fn(), del: jest.fn() },
},
],
}).compile();

service = module.get<MarketsService>(MarketsService);
cacheManager = module.get(CACHE_MANAGER);
});

it('pauseMarket() invalidates trending, active-list, and per-market cache keys', async () => {
const market = makeMarket();
marketsRepository.findOne.mockResolvedValue(market);
sorobanService.pauseMarket.mockResolvedValue({ tx_hash: 'abc' });
marketsRepository.save.mockResolvedValue({ ...market, is_paused: true });

await service.pauseMarket('market-1', mockAdmin);

expect(cacheManager.del).toHaveBeenCalledWith(
CACHE_WARMING_KEYS.trendingEvents,
);
expect(cacheManager.del).toHaveBeenCalledWith(
CACHE_WARMING_KEYS.activeEvents,
);
expect(cacheManager.del).toHaveBeenCalledWith(
CACHE_WARMING_KEYS.popularEventDetail('market-1'),
);
});

it('pauseMarket() does not invalidate cache when rejected (not admin)', async () => {
marketsRepository.findOne.mockResolvedValue(makeMarket());

await expect(
service.pauseMarket('market-1', { id: 'user-1', role: 'user' } as User),
).rejects.toThrow(ForbiddenException);
expect(cacheManager.del).not.toHaveBeenCalled();
});

it('resumeMarket() invalidates trending, active-list, and per-market cache keys', async () => {
const market = makeMarket({ is_paused: true });
marketsRepository.findOne.mockResolvedValue(market);
sorobanService.resumeMarket.mockResolvedValue({ tx_hash: 'def' });
marketsRepository.save.mockResolvedValue({ ...market, is_paused: false });

await service.resumeMarket('market-1', mockAdmin);

expect(cacheManager.del).toHaveBeenCalledWith(
CACHE_WARMING_KEYS.trendingEvents,
);
expect(cacheManager.del).toHaveBeenCalledWith(
CACHE_WARMING_KEYS.activeEvents,
);
expect(cacheManager.del).toHaveBeenCalledWith(
CACHE_WARMING_KEYS.popularEventDetail('market-1'),
);
});

it('resumeMarket() does not invalidate cache when rejected (not paused)', async () => {
marketsRepository.findOne.mockResolvedValue(
makeMarket({ is_paused: false }),
);

await expect(
service.resumeMarket('market-1', mockAdmin),
).rejects.toThrow(ConflictException);
expect(cacheManager.del).not.toHaveBeenCalled();
});

it('stale-read: pause then read reflects invalidated detail cache', async () => {
const market = makeMarket();
cacheManager.get.mockResolvedValue({ ...market, is_paused: false });
marketsRepository.findOne.mockResolvedValue(market);
sorobanService.pauseMarket.mockResolvedValue({ tx_hash: 'abc' });
marketsRepository.save.mockResolvedValue({ ...market, is_paused: true });

await service.pauseMarket('market-1', mockAdmin);

expect(cacheManager.del).toHaveBeenCalledWith(
CACHE_WARMING_KEYS.popularEventDetail('market-1'),
);
});
});
39 changes: 26 additions & 13 deletions backend/src/markets/markets.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,21 @@ export class MarketsService {
@Inject(CACHE_MANAGER) private readonly cacheManager: Cache,
) {}

/**
* Centralized cache invalidation for any market state mutation.
* Clears the in-memory trending cache plus the trending/active list-level
* keys and the per-market detail key so stale reads can't occur after
* update/pause/resume/cancel/resolve.
*/
private async invalidateMarketCaches(marketId: string): Promise<void> {
this.trendingCache = null;
await Promise.all([
this.cacheManager.del(CACHE_WARMING_KEYS.trendingEvents),
this.cacheManager.del(CACHE_WARMING_KEYS.activeEvents),
this.cacheManager.del(CACHE_WARMING_KEYS.popularEventDetail(marketId)),
]);
}

/**
* Get prediction statistics for a market - anonymous outcome counts only
* Does NOT expose individual user stakes or identities
Expand Down Expand Up @@ -321,7 +336,9 @@ export class MarketsService {
market.category = dto.category;
}

return await this.marketsRepository.save(market);
const saved = await this.marketsRepository.save(market);
await this.invalidateMarketCaches(saved.id);
return saved;
}

async resolveMarket(id: string, outcome: string): Promise<Market> {
Expand Down Expand Up @@ -353,11 +370,7 @@ export class MarketsService {
const saved = await this.marketsRepository.save(market);

// Invalidate caches immediately after market state changes
this.trendingCache = null;
await this.cacheManager.del(CACHE_WARMING_KEYS.trendingEvents);
await this.cacheManager.del(
CACHE_WARMING_KEYS.popularEventDetail(saved.id),
);
await this.invalidateMarketCaches(saved.id);

await this.webhookDispatcher.emit('market.resolved', {
id: saved.id,
Expand Down Expand Up @@ -583,11 +596,7 @@ export class MarketsService {
const saved = await this.marketsRepository.save(market);

// Invalidate caches immediately after market state changes
this.trendingCache = null;
await this.cacheManager.del(CACHE_WARMING_KEYS.trendingEvents);
await this.cacheManager.del(
CACHE_WARMING_KEYS.popularEventDetail(saved.id),
);
await this.invalidateMarketCaches(saved.id);

return saved;
} catch (err) {
Expand Down Expand Up @@ -797,7 +806,9 @@ export class MarketsService {
}

market.is_paused = true;
return await this.marketsRepository.save(market);
const saved = await this.marketsRepository.save(market);
await this.invalidateMarketCaches(saved.id);
return saved;
}

async resumeMarket(id: string, user: User): Promise<Market> {
Expand Down Expand Up @@ -833,7 +844,9 @@ export class MarketsService {
}

market.is_paused = false;
return await this.marketsRepository.save(market);
const saved = await this.marketsRepository.save(market);
await this.invalidateMarketCaches(saved.id);
return saved;
}

async removeBookmark(marketId: string, user: User): Promise<void> {
Expand Down
Loading