Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes push-notification payload generation so each pushed message gets its own unique notificationId, and aligns Entra mock-auth wiring in additional apps when MOCK_ENTRA_AUTH is enabled.
Changes:
- Update
wasteandsurveyapp configs to swap inMockEntraTokenAuthenticationwhenMOCK_ENTRA_AUTHis true. - Ensure per-device notifications don’t share the same
contextobject by deep-copying it during duplication. - Add a test asserting pushed Firebase messages contain unique
notificationIdvalues per device.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| waste/apps.py | Fixes MOCK_ENTRA_AUTH branch to actually use the mock authentication class. |
| survey/apps.py | Fixes MOCK_ENTRA_AUTH branch to actually use the mock authentication class. |
| notification/crud.py | Deep-copies context when duplicating notifications to prevent shared mutation during push. |
| notification/tests/test_crud.py | Adds regression test ensuring pushed notificationIds are unique across devices. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes push-notification payload generation so each pushed message gets its own unique notificationId, and aligns Entra mock-auth wiring in additional apps when MOCK_ENTRA_AUTH is enabled.
Changes:
Note: code co-authored by copilot