Integration test using template #75
Conversation
# Conflicts: # ice-rest-catalog/src/main/java/com/altinity/ice/rest/catalog/Main.java
|
The testcontainers version we have is too old, I'm getting a Docker client version error |
xieandrew
left a comment
xieandrew
left a comment
There was a problem hiding this comment.
Some initial comments from a first look
|
|
||
| assert hasSepalLength | ||
| : "Scan output should contain sepal length column data. Output: " | ||
| + combinedOutput.substring(0, Math.min(500, combinedOutput.length())); |
There was a problem hiding this comment.
This result could be stored in a variable and reused
| assert createNsExitCode == 0 : "Create namespace command should succeed"; | ||
|
|
||
| // Use existing iris parquet file | ||
| String testParquetPath = "examples/localfileio/iris.parquet"; |
There was a problem hiding this comment.
Not sure if it's ideal to have tests depend on files in the examples folder, maybe we should copy this to the test resources.
| echo "✓ Created namespace: ${NAMESPACE_NAME}" | ||
|
|
||
| # List namespaces to verify | ||
| {{ICE_CLI}} --config {{CLI_CONFIG}} list-namespaces |
There was a problem hiding this comment.
This command doesn't work:
Unmatched argument at index 2: 'list-namespaces'
Did you mean: ice delete-namespace or ice describe?
| * | ||
| * <p>This class uses Jackson/SnakeYAML annotations for YAML deserialization. | ||
| */ | ||
| public class ScenarioConfig { |
There was a problem hiding this comment.
Is it possible to use records for Jackson ObjectMapper? Would reduce boilerplate
| } | ||
|
|
||
| /** Result of executing a single script. */ | ||
| public static class ScriptExecutionResult { |
Integration test using template