-
Notifications
You must be signed in to change notification settings - Fork 484
add TOF channel in TPC timeseries #14945
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
REQUEST FOR PRODUCTION RELEASES: This will add The following labels are available |
|
Hi @shahor02 @miranov25 , |
|
Hello @noferini, The modification appears to be harmless – it is simply an addition. Marian |
|
Hi @miranov25 , |
|
Hi @miranov25 @noferini , |
shahor02
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks fine to me.
|
Hello @matthias-kleiner, @noferini To spot obvious problems (such as missing or undefined variables), 100 TFs is sufficient. As it is only an addition, such a check will be sufficient. @matthias-kleiner , can you run it at GSI? |
|
Hallo @noferini @matthias-kleiner provided test file. I made fast checks. It looks fine. I di not see some obvious problem in the TPC information. I assume the code can be merged Regards /lustre/alice/tpcdata/Run3/SCDprodTests/fullRec/pp2025/batches/unbinned/LHC25am.batch6_part2.b5p/567546.677kHz/0000/time_series_tracks_Merged.root
|
|
Dear @matthias-kleiner @miranov25 , |

Dear @miranov25 ,
if you agree I added the info about tof channel inside the sector (short).
This would help to check the calibration quality vs electronic modules and potentially to have a look to timewalk effect (time correlation with position inside the pad -> which requires mapping on electronics)
I hope I did everything correct but if you have any comment let me know.
Best,
Francesco