Skip to content

Conversation

@noferini
Copy link
Collaborator

@noferini noferini commented Jan 7, 2026

Dear @miranov25 ,
if you agree I added the info about tof channel inside the sector (short).

This would help to check the calibration quality vs electronic modules and potentially to have a look to timewalk effect (time correlation with position inside the pad -> which requires mapping on electronics)

I hope I did everything correct but if you have any comment let me know.
Best,
Francesco

@github-actions
Copy link
Contributor

github-actions bot commented Jan 7, 2026

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

@noferini
Copy link
Collaborator Author

Hi @shahor02 @miranov25 ,
is this PR fine with you?
Cheers,
Francesco

@miranov25
Copy link
Contributor

Hello @noferini,

The modification appears to be harmless – it is simply an addition.
I hope it will not cause any side effects.
@noferini, could you create a small time series data with your modification and post it somewhere? I can check it using the TTree Draw command. I assume you ahve some tests.
@matthias-kleiner, could you check it at GSI?

Marian

@noferini
Copy link
Collaborator Author

Hi @miranov25 ,
what shall I run to produce it?
Cheers,
Francesco

@matthias-kleiner
Copy link
Contributor

Hi @miranov25 @noferini ,
I can try to run it locally and provide you the time-series. How much TFs do you need? Are ~100 TFs enough?

Copy link
Collaborator

@shahor02 shahor02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks fine to me.

@miranov25
Copy link
Contributor

Hello @matthias-kleiner, @noferini

To spot obvious problems (such as missing or undefined variables), 100 TFs is sufficient. As it is only an addition, such a check will be sufficient.

@matthias-kleiner , can you run it at GSI?

@miranov25
Copy link
Contributor

Hallo @noferini

@matthias-kleiner provided test file. I made fast checks. It looks fine. I di not see some obvious problem in the TPC information.
I have to make unit tests later to be more confident ....

I assume the code can be merged

Regards
Marian

/lustre/alice/tpcdata/Run3/SCDprodTests/fullRec/pp2025/batches/unbinned/LHC25am.batch6_part2.b5p/567546.677kHz/0000/time_series_tracks_Merged.root

image

@noferini
Copy link
Collaborator Author

Dear @matthias-kleiner @miranov25 ,
many thanks for the quick check.
Then I merge it.
Cheers,

@noferini noferini merged commit c21d7d7 into AliceO2Group:dev Jan 12, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants