Added PersistentDescriptorSet::updateBindings#85
Merged
Conversation
|
А я всегда говорил, нормально делай — нормально будет! 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This method shall allow bindless streaming, as before etna had ho way of updating a dset after creation. Only done for persistent dsets, as dynamic dsets live one frame and can just be created with everything at once.
To allow this, also changed binding structures to have pointers instead of refs (I believe it is not a good practice to have references as fields, as it silently makes the structure pinned in memory) to allow bindings vector modifications, and updated the 'write_set' function to allow generating writes only for some of the bindings.