Skip to content

Added compare options to samplers for shadow sampling. #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mrkol merged 2 commits into from
Jan 17, 2026
Merged

Added compare options to samplers for shadow sampling. #83

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d0a00e0
Added compare options to samplers for shadow sampling.
Oct 23, 2025
937db01
Corrected comment on BlockingTransferHelper::uploadImage (we do suppo…
Dec 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion etna/include/etna/BlockingTransferHelper.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ class BlockingTransferHelper
OneShotCmdMgr& cmd_mgr, std::span<std::byte> dst, const Buffer& src, std::uint32_t offset);


// NOTE: uploads only mip 0 and layer 0 for now and doesn't support 3D images
// NOTE: for now doesn't support 3D images
void uploadImage(
OneShotCmdMgr& cmd_mgr,
Image& dst,
Expand Down
2 changes: 2 additions & 0 deletions etna/include/etna/Sampler.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@ class Sampler
std::string_view name;
float minLod = 0.0f;
float maxLod = VK_LOD_CLAMP_NONE;
bool compareEnable = false;
vk::CompareOp compareOp = vk::CompareOp::eLessOrEqual;
};

explicit Sampler(CreateInfo info);
Expand Down
3 changes: 2 additions & 1 deletion etna/source/Sampler.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,10 @@ Sampler::Sampler(CreateInfo info)
.addressModeW = info.addressMode,
.mipLodBias = 0.0f,
.maxAnisotropy = 1.0f,
.compareEnable = static_cast<vk::Bool32>(info.compareEnable),
.compareOp = info.compareOp,
.minLod = info.minLod,
.maxLod = info.maxLod,
.borderColor = vk::BorderColor::eFloatOpaqueWhite,
};
sampler = unwrap_vk_result(etna::get_context().getDevice().createSamplerUnique(createInfo));
etna::set_debug_name(sampler.get(), info.name.data());
Expand Down