Add conda packaging#64
Open
Zehen-249 wants to merge 1 commit into
Open
Conversation
mhsuhail00
reviewed
Apr 30, 2026
mhsuhail00
reviewed
Apr 30, 2026
mhsuhail00
reviewed
Apr 30, 2026
mhsuhail00
reviewed
Apr 30, 2026
mhsuhail00
left a comment
mhsuhail00
left a comment
Collaborator
There was a problem hiding this comment.
Recheck the comments
Author
|
Checks Done |
mhsuhail00
reviewed
Apr 30, 2026
Collaborator
There was a problem hiding this comment.
@Zehen-249
This refactoring changes may not be required in this PR.
Author
There was a problem hiding this comment.
that caused issue during packaging, that's why refactored
Collaborator
|
The ospgrillage module should be a submodule i think. But it is not so. |
Author
osdagbridge - module, both packaged together in osdagbridge module, in future when we want to remove ospgrillage dependency we just have to remove the folder. ospgrillage is not a submodule in sense of submodule theory. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ospgrillage packeged as submodule