Fix per-girder stiffener preservation and render longitudinal stiffeners on both sides#186
Open
MdTalha17 wants to merge 5 commits into
Open
Fix per-girder stiffener preservation and render longitudinal stiffeners on both sides#186MdTalha17 wants to merge 5 commits into
MdTalha17 wants to merge 5 commits into
Conversation
…tom flanges details
…d and the Yes/No inputs were not working for intermediate and longitudinal stiffeners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves issues with per-girder stiffeners and girder properties being globally reset to defaults during solve execution, and fixes the 3D CAD representation of longitudinal stiffeners.
Key Fixes:
solve_extend_basic_input_dict()from deleting and overwriting user-configured inputs indefaults.pyon subsequent design solver runs."All",None, or empty values with solved defaults, avoiding conversion/multiplicationTypeErrorexceptions.stiffeners_dictdown toBridgeParametersDTOso the CAD generator actually receives and renders the girder-specific stiffeners configurations.Detailed Changes
1. Core Bridge Defaults Extension
src/osdagbridge/core/bridge_types/plate_girder/defaults.py_on_no_of_girders_changed()to check girder indices via regex (e.g., matching.G{i}).no_of_bracings) are deleted as stale, preserving valid configurations.key not in working_input_dict) to prevent resetting existing user inputs to global defaults."All",None, or empty string""girder dimensions in Custom design mode to prevent solver crash errors.2. CAD Parameters DTO Mapping
src/osdagbridge/core/bridge_types/plate_girder/plategirderbridge.pystiffeners_dictintoBridgeParametersDTOinsideget_3d_cad_parameters(), allowing the CAD generator to obtain per-girder configurations.3. Girder Geometry Builder
src/osdagbridge/core/bridge_components/super_structure/plate_girder/builder.pybuild_plate_girder_geometry()within the longitudinal stiffeners block to construct and append plates on both sides of the web:seg.tw / 2 + long_stiff_width / 2-seg.tw / 2 - long_stiff_width / 2