fix: correct Content-Length header in OTP download handler#327
Open
airouboss wants to merge 1 commit into
Open
fix: correct Content-Length header in OTP download handler#327airouboss wants to merge 1 commit into
airouboss wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found a bug in the OTP download handler in
AdaptixServer/core/connector/tc_otp.go around line 178.
The Content-Length header was being set incorrectly. The original
code used string(rune(fileInfo.Size())) which converts the file size
into a Unicode character instead of a number. So a 65 byte file would
send Content-Length: A instead of Content-Length: 65. For files over
1MB it gets even worse and the value becomes meaningless.
Fixed it by using strconv.FormatInt which correctly converts the file
size to a decimal string.