Skip to content

Conversation

@RohitKushvaha01
Copy link
Member

@RohitKushvaha01 RohitKushvaha01 commented Dec 29, 2025

This PR mutes ads if the app is launched between 10 PM and 5 AM. During this time, any video ads will have their volume set to zero, though this is not guaranteed. This may also affect the eCPM of ads during this time range, as already discussed.

Closes #1293

@gemini-code-assist
Copy link

Summary of Changes

Hello @RohitKushvaha01, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request integrates a user-centric feature that automatically mutes advertisements during specified 'quiet hours' to prevent disturbances. By configuring the AdMob SDK to respect these times, the application aims to provide a less intrusive experience for users, particularly during late-night or early-morning usage.

Highlights

  • Quiet Hours Logic: Introduced a new feature to define and detect 'quiet hours' between 10 PM and 5 AM based on the current local time.
  • Ad Muting: Implemented AdMob configuration to automatically mute application ads and set their volume to zero during the detected quiet hours, enhancing user experience.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a 'quiet hours' feature to mute ads between 10 PM and 5 AM. The implementation is straightforward and correct. My main feedback is to replace the hardcoded start and end hours with named constants to improve code readability and maintainability. This also makes it easier to adjust these times in the future or expose them as user settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AD goes suddenly playing after used search

1 participant