Refactor dep versions into versions.sh and patch torch wheel naming#439
Merged
puneetmatharu merged 1 commit intoARM-software:mainfrom Feb 11, 2026
Conversation
puneetmatharu
force-pushed
the
refactor-dep-versions-into-versions-sh
branch
from
e9b4145 to
a3c49ef
Compare
puneetmatharu
changed the title
versions.shversions.sh and patch torch wheel naming
puneetmatharu
force-pushed
the
refactor-dep-versions-into-versions-sh
branch
from
a3c49ef to
9ffea41
Compare
Contributor
Author
|
Can confirm from the CI checks that the output wheel name is 2026-02-11T04:40:30.4728807Z + torch_wheel_name=torch-2.11.0.dev20260129-cp312-cp312-manylinux_2_28_aarch64.whl |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the major project versions we wish to change from release to release into a
versions.shthat can besource-d by any bash script that needs to know which hash/version of those projects that we're using. It's a much cleaner approach than forcing the scripts to pass it from one to another.Tip
It is highly recommended that scripts that require the use of
versions.shuseset -uto error if a variable (i.e. version/tag for our purpose) is not set and thus the required version/tag has not been set. (Currently every script that usesversions.shalready hasset -uset.Important
This PR supersedes #438. Only one of these two PRs should be merged in.