Skip to content

Patch torch wheel naming #438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
puneetmatharu wants to merge 1 commit into from
Closed

Patch torch wheel naming #438

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ML-Frameworks/pytorch-aarch64/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ where `YY` is the year, and `MM` the month of the increment.

### Fixed

## [r26.02] 2026-02-09
## [r26.02] 2026-02-11
https://github.com/ARM-software/Tool-Solutions/tree/r26.02

### Added
Expand All @@ -30,7 +30,7 @@ https://github.com/ARM-software/Tool-Solutions/tree/r26.02

### Changed
- Updates hashes for:
- `PYTORCH_HASH` to `77da53a7356e033e3fc1e03fdd960fc4ad117882`, 2.11.0.dev20260130 from viable/strict, Jan 30th.
- `PYTORCH_HASH` to `77da53a7356e033e3fc1e03fdd960fc4ad117882`, 2.11.0.dev20260129 from viable/strict, Jan 29th.
- `IDEEP_HASH` to `bbb9ffb9e0c401ca058b7f35a6ebe7d0e08ffd34`, from ideep_pytorch, Jan 30th.
- `ONEDNN_HASH` to `804f364c04ad8a763d534abaabc99bf99c2754e0`, from main, Jan 30th.
- `TORCH_AO_HASH` to `30fcb156945ecacd515775414d37c09bfe60727e`, from main, Jan 30th.
Expand Down
6 changes: 5 additions & 1 deletion ML-Frameworks/pytorch-aarch64/build-wheel.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,11 @@ docker_exec rm -rf "${PYTORCH_CONTAINER_DIR}/dist"
# commit, this allows us to also install the matching torch* packages, set in
# the Dockerfile. This is what PyTorch does in its nightly pipeline, see
# pytorch/.ci/aarch64_linux/aarch64_wheel_ci_build.py for this logic.
build_date=$(cd "$PYTORCH_LOCAL_DIR" && git log --pretty=format:%cs -1 | tr -d '-')
# NOTE: This relies on the fact that we only ever perform a shallow clone of the
# PyTorch repo so the first commit is the latest commit on the branch we clone,
Copy link
Copy Markdown
Contributor

@nSircombe nSircombe Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fix is fine for a docker build, but if you're using TS as a local dev environment, you're at risk of some unexpected version suffixes?

Copy link
Copy Markdown
Contributor

@jondea jondea Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a tricky one! Perhaps we could cheat and override the date when we apply the patches instead?

Copy link
Copy Markdown
Contributor Author

@puneetmatharu puneetmatharu Feb 10, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to consider moving these hash values into a separate e.g. versions.sh and source that file in any shell script that needs it. It's better than forcing scripts to pass values between each other

Copy link
Copy Markdown
Contributor Author

@puneetmatharu puneetmatharu Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See optional replacement PR here. Requires more changes but handles things in a cleaner way. Have been meaning to make this change for a while...

# which is what we want to base the version on. If this ever changes, we may need
# to update this logic.
build_date=$(cd "$PYTORCH_LOCAL_DIR" && git log --reverse --pretty=format:%cs -1 | tr -d '-')
version=$(cat "$PYTORCH_LOCAL_DIR/version.txt" | tr -d "[:space:]")
OVERRIDE_PACKAGE_VERSION="${version%??}.dev${build_date}${TORCH_RELEASE_ID:+"+$TORCH_RELEASE_ID"}"

Expand Down
2 changes: 1 addition & 1 deletion ML-Frameworks/pytorch-aarch64/get-source.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ source ../utils/git-utils.sh

set -eux -o pipefail

PYTORCH_HASH=77da53a7356e033e3fc1e03fdd960fc4ad117882 # 2.11.0.dev20260130 from viable/strict, Jan 30th
PYTORCH_HASH=77da53a7356e033e3fc1e03fdd960fc4ad117882 # 2.11.0.dev20260129 from viable/strict, Jan 29th
IDEEP_HASH=bbb9ffb9e0c401ca058b7f35a6ebe7d0e08ffd34 # From ideep_pytorch, Jan 30th
ONEDNN_HASH=804f364c04ad8a763d534abaabc99bf99c2754e0 # From main, Jan 30th
TORCH_AO_HASH=30fcb156945ecacd515775414d37c09bfe60727e # From main, Jan 30th
Expand Down
2 changes: 1 addition & 1 deletion ML-Frameworks/tensorflow-aarch64/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ where `YY` is the year, and `MM` the month of the increment.

### Fixed

## [r26.02] 2026-02-09
## [r26.02] 2026-02-11
https://github.com/ARM-software/Tool-Solutions/tree/r26.02

### Added
Expand Down