Feat/gw fix signature mismatch - #870
Open
gabeweisz wants to merge 9 commits into
Open
Conversation
Clean up 124 unused imports (ruff F401) across library code, tests, examples, and notebooks. Replace openpyxl availability checks with importlib.util.find_spec to avoid side-effect-only imports. Co-authored-by: Cursor <cursoragent@cursor.com>
Apply black 26.1.0 to files flagged by CI lint job. Co-authored-by: Cursor <cursoragent@cursor.com>
Clean up 35 unused local variables (ruff F841) by removing dead assignments, using underscore placeholders in tuple unpacks, and dropping unused exception bindings. Co-authored-by: Cursor <cursoragent@cursor.com>
Run unused import and unused assignment checks on changed Python files, matching the existing Black lint scope. Co-authored-by: Cursor <cursoragent@cursor.com>
Replace absolute TraceLens package imports with relative imports in Trace2Tree, TraceDiff, TreePerf, and TraceUtils. Lazy-load merge_capture_trace_into_graph in TreePerfAnalyzer.from_file and drop eager moe_flydsl re-export from extensions __init__. Co-authored-by: Cursor <cursoragent@cursor.com>
Add acyclic_siblings contract for TraceLens, refactor pseudo-op extension registry and graph capture merge to break import cycles, and run lint-imports in the lint workflow. Co-authored-by: Cursor <cursoragent@cursor.com>
Align perf-model bytes/bytes_bwd overrides with base classes, call base inits in MoE/quant/attention subclasses, and unify JAX/PyTorch tree and GPU analyser method signatures so subclasses are LSP-compatible. Co-authored-by: Cursor <cursoragent@cursor.com>
gabeweisz
requested review from
Ahmedhasssan-aig,
ajassani,
devalshahamd,
kyle-hoffmeyer,
spandoesai and
tsrikris
as code owners
July 31, 2026 19:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix mismatched signatures in child classes and classes that do not call the parent init in their init function.
Sequenced after #869