Fix magpie profiler flags - #755
Open
kyle-hoffmeyer wants to merge 1 commit into
Open
Conversation
…rofiler_dir path Three fixes: 1. Fix benchmark_lib.sh sed pattern: InferenceX uses num_prompts="$max_concurrency" not num_prompts="$((max_concurrency * 1))". The old pattern silently no-ops, leaving num_prompts at CONC and causing the benchmark to finish before the profiling delay window is reached. 2. Add missing required --profiler-config.profiler torch and --profiler-config.torch_profiler_dir flags to the common vLLM flags section. Without these, vLLM's ProfilerConfig validator raises a pydantic ValueError at startup and refuses to launch. 3. Fix capture_torch_profiler_dir to actually control the capture trace output path. Previously gpu_model_runner.py ignored the flag's value and derived the path as torch_profiler_dir + "/capture_traces". All 8 vLLM patches updated to use capture_torch_profiler_dir directly as trace_dir. Co-Authored-By: Claude Sonnet 4 <noreply@anthropic.com>
kyle-hoffmeyer
force-pushed
the
fix/magpie-skill/profiler-flags
branch
from
June 20, 2026 00:26
2ec0d86 to
e971881
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
profilerflag andprofiler_dirneed to be set but are currently not required in the skill file, causing the profiling to fail before the agent corrects itself.From vllm/config/profiler.py that TraceLens patches:
and
Now the flags are correctly passed into
EXTRA_VLLM_ARGS.Additionally, previously the patches ignored whatever
profiler-config.capture_torch_profiler_dirwas set to and always set it to torch_profiler_dir + "/capture_traces". Now,profiler-config.capture_torch_profiler_dirproperly sets the capture trace directory