Added warning messages for debugging - #739
Draft
devalshahamd wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces new diagnostic features to improve performance analysis and debugging in the PyTorch inference report generation and trace merging processes. The main changes add automated warnings for potential performance issues related to synthetic and uncategorized operations, and enhance failure reporting during graph capture merges.
Performance diagnostics and reporting improvements:
diag_sweep_unified_perf_summaryfunction togenerate_perf_report_pytorch_inference.py, which scans the unified performance summary and prints diagnostic warnings if synthetic or uncategorized operations exceed a configurable runtime threshold. This helps users quickly identify potential inefficiencies.generate_perf_report_pytorchworkflow, ensuring that these warnings are automatically generated as part of the performance report.Graph capture merge diagnostics:
merge_capture_trace_into_graphto use an explicitstepcounter, enabling more informative diagnostics during processing.merge_capture_trace_into_graphby printing a detailed diagnostic message (DIAG) when graph capture merging fails, including step number and event/root counts for both capture and graph traces. This provides clearer context for debugging merge failures.