fix: bump PRIMUS_TURBO_COMMIT to 69deeab7 to fix loss NaN - #933
Conversation
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
9dc1c88 to
d4e3d60
Compare
There was a problem hiding this comment.
Pull request overview
This PR updates the CI workflow’s pinned Primus-Turbo commit SHA, aligning CI builds with a newer upstream snapshot intended to address a loss NaN issue.
Changes:
- Bump
PRIMUS_TURBO_COMMITin.github/workflows/ci.yamlto69deeab7523ae86a735f030433147c2a1804acd6.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
.github/workflows/ci.yaml:26
- This commit pin lost the inline rationale/reference comment that other pinned dependencies in this workflow include (and that
benchmark.yamlalso follows). Keeping a short note (e.g., what issue/PR it fixes) helps traceability when pins need to be revisited.
PRIMUS_TURBO_COMMIT: 69deeab7523ae86a735f030433147c2a1804acd6
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
|
flydsl 0.3.0 (released 2026-08-01) removed primus-turbo declared Upstream already fixed it in |
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
Suppressed comments (1)
.github/workflows/ci.yaml:26
- The PR title says PRIMUS_TURBO_COMMIT is being bumped to
69deeab7to fix loss NaN, but this workflow now pins2f622de6…. Please align the pinned commit with the PR title (or update the PR title) so reviewers/CI users can unambiguously track the intended Primus-Turbo revision.
PRIMUS_TURBO_COMMIT: 2f622de6a29ab711925e8fe6bcc763be76ac2699 # fix: loss NaN issue (Primus-Turbo bump); fix: fixed flydsl version (#446)
Co-authored-by: Claude Opus 5 <noreply@anthropic.com> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
No description provided.