Skip to content

fix: bump PRIMUS_TURBO_COMMIT to 69deeab7 to fix loss NaN - #933

Merged
WangLingxun merged 3 commits into
mainfrom
fix/bump-primus-turbo-loss-nan
Aug 7, 2026
Merged

fix: bump PRIMUS_TURBO_COMMIT to 69deeab7 to fix loss NaN#933
WangLingxun merged 3 commits into
mainfrom
fix/bump-primus-turbo-loss-nan

Conversation

@zhenhuang12

Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI lite review requested due to automatic review settings July 29, 2026 07:37
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@zhenhuang12
zhenhuang12 force-pushed the fix/bump-primus-turbo-loss-nan branch from 9dc1c88 to d4e3d60 Compare July 29, 2026 07:39

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the CI workflow’s pinned Primus-Turbo commit SHA, aligning CI builds with a newer upstream snapshot intended to address a loss NaN issue.

Changes:

  • Bump PRIMUS_TURBO_COMMIT in .github/workflows/ci.yaml to 69deeab7523ae86a735f030433147c2a1804acd6.

Comment thread .github/workflows/ci.yaml Outdated
Copilot AI review requested due to automatic review settings July 29, 2026 07:39

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (1)

.github/workflows/ci.yaml:26

  • This commit pin lost the inline rationale/reference comment that other pinned dependencies in this workflow include (and that benchmark.yaml also follows). Keeping a short note (e.g., what issue/PR it fixes) helps traceability when pins need to be revisited.
  PRIMUS_TURBO_COMMIT: 69deeab7523ae86a735f030433147c2a1804acd6

@zhenhuang12 zhenhuang12 changed the title fix(ci): bump PRIMUS_TURBO_COMMIT to 69deeab7 for loss NaN fix chore: bump PRIMUS_TURBO_COMMIT to 69deeab7 to fix loss NaN Jul 29, 2026
@zhenhuang12 zhenhuang12 changed the title chore: bump PRIMUS_TURBO_COMMIT to 69deeab7 to fix loss NaN fix: bump PRIMUS_TURBO_COMMIT to 69deeab7 to fix loss NaN Jul 29, 2026
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings July 29, 2026 07:48

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

@WangLingxun

WangLingxun commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator

flydsl 0.3.0 (released 2026-08-01) removed flydsl/expr/buffer_ops.py and
flydsl/expr/vector.py, which aiter, primus-turbo and Primus's own
DeepSeek-V4 kernels all import at module scope.

primus-turbo declared flydsl>=0.2.0 with no upper bound, so the turbo install
(a separate pip invocation from aiter's) resolved to 0.3.0. 69deeab7
(2026-07-29) still carries that unbounded requirement, so this bump would
rebuild the image and land on 0.3.0 again.

Upstream already fixed it in
Primus-Turbo 2f622de6

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings August 7, 2026 02:15

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

Suppressed comments (1)

.github/workflows/ci.yaml:26

  • The PR title says PRIMUS_TURBO_COMMIT is being bumped to 69deeab7 to fix loss NaN, but this workflow now pins 2f622de6…. Please align the pinned commit with the PR title (or update the PR title) so reviewers/CI users can unambiguously track the intended Primus-Turbo revision.
  PRIMUS_TURBO_COMMIT: 2f622de6a29ab711925e8fe6bcc763be76ac2699 # fix: loss NaN issue (Primus-Turbo bump); fix: fixed flydsl version (#446)

@WangLingxun
WangLingxun merged commit 7cff62a into main Aug 7, 2026
13 of 16 checks passed
eshaw2 pushed a commit that referenced this pull request Aug 7, 2026
Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants