Skip to content

fix(cli): register framework executor under the kind the phase enqueues - #1087

Merged
chaojhou merged 1 commit into
mainfrom
fix/zgong/rename-framework
Aug 3, 2026
Merged

fix(cli): register framework executor under the kind the phase enqueues#1087
chaojhou merged 1 commit into
mainfrom
fix/zgong/rename-framework

Conversation

@ZhengGong-amd

Copy link
Copy Markdown
Collaborator

Summary

  • The FRAMEWORK phase enqueues per-candidate work with kind framework_agent (matching protocol/action_surfaces.py COORDINATOR_INTERNAL_ACTIONS and actions/_meta/framework_agent.yaml), but _register_executors registered FrameworkAgentExecutor under the stale key framework.
  • With no executor matching the enqueued kind, every PR candidate discovered by the framework agent was stamped no_result_failed instead of being benchmarked.
  • Renames the registration key to framework_agent and tightens the wiring test to assert the new key is present and the stale framework key is gone, so the mismatch cannot silently come back.

Test plan

  • pytest src/hyperloom/inference_optimizer/tests/test_cli_executors_wiring.py
  • Run a session with the framework agent enabled and confirm discovered PR candidates get real benchmark results rather than no_result_failed.

Made with Cursor

The FRAMEWORK phase enqueues candidates with kind "framework_agent"
(per action_surfaces.COORDINATOR_INTERNAL_ACTIONS and
actions/_meta/framework_agent.yaml), but the executor was registered as
"framework", so every discovered PR candidate was stamped
no_result_failed instead of being benchmarked.

Co-authored-by: Cursor <cursoragent@cursor.com>
@ZhengGong-amd
ZhengGong-amd requested a review from a team as a code owner August 3, 2026 10:43
@chaojhou
chaojhou merged commit 244523c into main Aug 3, 2026
25 of 26 checks passed
@chaojhou
chaojhou deleted the fix/zgong/rename-framework branch August 3, 2026 11:10
@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown

CI E2E report — ✅ Succeeded

item value
result ✅ Succeeded
model Qwen/Qwen3-0.6B (dense)
resources 1× GPU, TP=1
PR branch fix/zgong/rename-framework
commit 1479eed856b237c09b761127c05d9abf6b4fb880
session_id 076c5029-f611-44f9-b0cd-c2d0087ef537
queue → dispatch 0s
run time 153m 33s
total 153m 33s

details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants