fix(cli): register framework executor under the kind the phase enqueues - #1087
Merged
Conversation
The FRAMEWORK phase enqueues candidates with kind "framework_agent" (per action_surfaces.COORDINATOR_INTERNAL_ACTIONS and actions/_meta/framework_agent.yaml), but the executor was registered as "framework", so every discovered PR candidate was stamped no_result_failed instead of being benchmarked. Co-authored-by: Cursor <cursoragent@cursor.com>
chaojhou
approved these changes
Aug 3, 2026
CI E2E report — ✅ Succeeded
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
framework_agent(matchingprotocol/action_surfaces.pyCOORDINATOR_INTERNAL_ACTIONSandactions/_meta/framework_agent.yaml), but_register_executorsregisteredFrameworkAgentExecutorunder the stale keyframework.no_result_failedinstead of being benchmarked.framework_agentand tightens the wiring test to assert the new key is present and the staleframeworkkey is gone, so the mismatch cannot silently come back.Test plan
pytest src/hyperloom/inference_optimizer/tests/test_cli_executors_wiring.pyno_result_failed.Made with Cursor