feat(forge): pass task identity and workload metadata to forge-loop - #74
Open
jiaqiang-dot-liu wants to merge 2 commits into
Open
feat(forge): pass task identity and workload metadata to forge-loop#74jiaqiang-dot-liu wants to merge 2 commits into
jiaqiang-dot-liu wants to merge 2 commits into
Conversation
Forward stable kernel identity and workload metadata to Forge while keeping scoring independent from external publication state. Co-authored-by: Cursor <cursoragent@cursor.com>
jiaqiang-dot-liu
requested review from
irvineoy,
sharareh-y and
sinarafati-amd
as code owners
August 3, 2026 02:34
jiaqiang-dot-liu
changed the title
irvineoy
reviewed
Aug 3, 2026
| cmd.extend(["--operator-name", logical_operator]) | ||
| if framework: | ||
| cmd.extend(["--framework", framework]) | ||
| if shapes: |
Collaborator
There was a problem hiding this comment.
[P1] The shape-v2 workload identity built here is no longer consumed by the current KernelForge CLI. On current main, --shapes-json is a hidden legacy/checkpoint-only option and --workload-key is explicitly ignored (declarations, warnings/behavior). Consequently, two tasks with the same source/operator but different shape regimes will not be isolated by the key promised in this PR's README. Please migrate this handoff to the current campaign/invocation-spec identity contract, or pin/probe a compatible KernelForge version and fail clearly instead of silently degrading.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forward stable kernel identity and workload metadata to Forge while keeping scoring independent from external publication state.