Skip to content

Bugfix - double write of the desired position#34

Merged
macmacal merged 8 commits into
humble-develfrom
bugfix/deterministic_memory
Oct 7, 2025
Merged

Bugfix - double write of the desired position#34
macmacal merged 8 commits into
humble-develfrom
bugfix/deterministic_memory

Conversation

@macmacal

@macmacal macmacal commented Oct 6, 2025

Copy link
Copy Markdown
Contributor

Description

After lots of debugging the integration of the driver with a UR5e project I believe i found the source of the problem: calling the write_output_bytes(); (which executes the modbus communication) when the mutex was locked in the time-critical block.

Note

For this particular PR please do the squash merge.

Motivation and context

  • Eliminate ros2_control's control_node frequency hiccups.

How has this been tested?

  • Manually with the real gripper mounted to the UR5e robot.
    • Connected via socat port forwarding.
    • Communication thread frequency: 100 Hz.
    • Control loop frequency: 500 Hz.
    • Additional modules (i.e. f/t sensor & cameras) were enabled.

Related PRs

Checklist

  • All TODOs in the code have been resolved or linked to a proper issue.
  • Code has been (auto)formatted.
  • Documentation (e.g., README, CHANGELOG, Wiki) has been updated.
  • All automated checks have passed.

Clickup task: 869amanuv

@macmacal macmacal requested a review from sivral October 6, 2025 16:23
@macmacal macmacal added the bug Something isn't working label Oct 6, 2025
@macmacal macmacal marked this pull request as draft October 6, 2025 16:29
@macmacal macmacal marked this pull request as ready for review October 6, 2025 22:17
Comment thread robotiq_hande_driver/hardware/src/hande_gripper.cpp Outdated

@sivral sivral left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@macmacal macmacal merged commit 90f0de6 into humble-devel Oct 7, 2025
1 check passed
@macmacal macmacal deleted the bugfix/deterministic_memory branch October 7, 2025 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] socat forward of gripper RS485 causes pipeline overflow in UR's RTDE

2 participants