Move the diagnostic skill into its owner home - #313
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 995b150559
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| - `aoa-session-recovery` in its explicit `diagnose` or `repair` mode | ||
| - `aoa-session-progression-lift` | ||
| - `aoa-quest-harvest` | ||
| - `aoa-session-harvest` in its explicit promotion mode |
There was a problem hiding this comment.
Keep diagnostic handoff targets schema-compatible
This handoff list now points agents at aoa-session-recovery and aoa-session-harvest, but the typed diagnostic surfaces still accept and emit the older targets: repair_handoff.schema.json/aoa_diagnose.py require aoa-session-self-repair, and the companion/review validators still require aoa-session-self-diagnose/aoa-quest-harvest. When an agent follows this new owner-skill guidance for a repair or harvest handoff, it will produce a route that the owner packets cannot validate or expose; keep these names aligned with the schemas/code or update the schemas, generator, and projection together.
Useful? React with 👍 / 👎.
| "bundles": [ | ||
| { | ||
| "name": "abyss-self-diagnostic-spine", | ||
| "path": "skills/abyss-self-diagnostic-spine", |
There was a problem hiding this comment.
Include admitted skills in Configs sync
This bundle is now advertised from skills/abyss-self-diagnostic-spine, but the source-to-runtime projection still omits the entire skills tree (managed_items in aoa_sync_configs.sh and SYNC_MANAGED_ITEMS only include compose/docs/mechanics/mcp/quests/scripts/schemas/stats/etc.). After a normal aoa-sync-configs, the deployed Configs mirror has no skills/port.manifest.json or bundle for profile/source-return resolution, and parity validation cannot catch the omission; add skills to the sync allowlists and mirror checks with this admission.
Useful? React with 👍 / 👎.
What changed
skills/abyss-self-diagnostic-spine/as the canonical owner package inabyss-stack, with a focusedSKILL.md, typed contract, progressively disclosed diagnosis procedure, and OpenAI presentation metadata.agents/skills/abyss-self-diagnostic-spineoverlay while preserving the owner-to-global projection route throughskills/port.manifest.jsonWhy
The previous overlay exposed a short instruction but did not give the runtime capability a canonical owner home or a complete operational contract. The new package preserves the original diagnosis function while making applicability, input/output ABI, freedom, effects, verification, termination, failure modes, provenance, relations, and lifecycle health explicit. It is designed to be globally advertised by the OS profile after merge, while
abyss-stackremains the source of truth.Manual behavioral evidence
The candidate was exercised in fresh Codex sessions before promotion, including:
aoa-session-recovery, loaded only after a verified repair handoffNo session trace, temporary fixture, or trial-only validator is committed.
Validation
skill-creator/scripts/quick_validate.py skills/abyss-self-diagnostic-spinepython scripts/validate_stack.pyThe KAG refresh touches many content-addressed shards because changed owner documents disperse anchors across shard hashes. The repository-standard one-change budget receipt records that reviewed generated delta; the standing budget was not raised.