Conversation
Add test data and reference output for the Umats MIMTP test suite. Files added: comparison/results_job_global-0.txt (reference results), data/Nellipsoids0.dat (ellipsoid/particle definitions), data/material.dat (material parameters and orientation), data/path.txt (test loading path and temperature), data/solver_control.inp (solver control parameters, executable), and data/solver_essentials.inp (solver type and rate). These provide input and expected output for regression tests of the MIMTP umat implementation.
Add MSVC dev environment and sccache actions to Windows jobs and enable sccache + Ninja integration. Install ninja in the editable install and CI steps, set SCCACHE_GHA_ENABLED and CMAKE_ARGS/CMAKE_*_LAUNCHER so scikit-build-core/CMake use sccache, and switch the Windows build to the Ninja generator. This speeds Windows builds by enabling compiler caching and ensures the compiler-launcher setting is honored.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces improvements to tangent mode propagation in the micromechanics code and adds a new regression test to ensure correct behavior when using a plastic (modular) matrix in the Mori-Tanaka homogenization. The main focus is on ensuring that the correct tangent mode is consistently used and tested throughout the codebase.
Tangent mode propagation improvements:
tangent_modeis explicitly copied in thestate_variablesassignment operator and in therotate_g2lmethod, so that the solver’s tangent mode parameter is always properly propagated and used by the kernels. [1] [2]umat_multi, explicitly set each sub-phase'stangent_modetosimcoon::tangent_continuumat the start of the localization process, preventing the caller's tangent mode from leaking into the localization schemes.Testing and validation:
test/Umats/MIMTP/TMIMTP.cppthat verifies the correct tangent mode is used in the incremental Mori-Tanaka formulation with a plastic (modular) matrix, guarding against regressions in tangent mode propagation.test/CMakeLists.txtso it is included in the test suite.