chore: set up Claude (superpowers) collaboration infrastructure#1360
Merged
Conversation
Establish docs/superpowers/ as the standard location for design specs and implementation plans produced via the Claude + superpowers workflow. - README.md explains the brainstorm → spec → plan → execute → verify flow - specs/ and plans/ subdirectories with .gitkeep placeholders - Include the spec and plan for this Claude collaboration setup itself Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Document chain33-specific conventions Claude (and humans new to the codebase) need to know: Makefile-wrapped git workflow, GOPATH path constraint, GOPROXY for CN users, layered module map, testing discipline, and pitfall list. The conventions cover the chain33 specifics that aren't visible from code alone — for instance, `make branch` / `make push` wrap git, `types/*.pb.go` shouldn't be hand-edited, and `.travis.yml` / `.gitlab-ci.yml` should not be touched without confirmation. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Two corrections from code review of the initial CLAUDE.md commit: - 模块计数:目录速查列了 18 个代码模块,文首误标为 19;修正 并说明 build/ 与 docs/ 不算代码模块 - gg18 TSS 实际位于 system/crypto/tss/gg18/,不在 p2p/ 下; 移除 p2p 段的错误括注,改在 system/ 段补充指引 Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Add team-shared Claude Code permissions for chain33. Allowlist covers: - make targets that are read-only or safely scoped (test, race, lint, coverage, fmt, depends, build, cli) — excludes push/sync/docker - go subcommands that don't mutate remote state - git read-only commands (status, diff, log, show, blame) - search/navigation utilities (ls, find, grep, rg, wc, file) - gh read commands (pr/issue/run view & list) Commands that mutate shared state (git push, make push, gh pr create, git reset --hard) stay outside the allowlist and prompt every time. Adjust .gitignore so .claude/settings.json (team config) is tracked while .claude/settings.local.json (personal overrides) stays ignored. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Three small corrections from the final code review:
- Add coverage_*.out and build/coverage/ to .gitignore so the claim in
CLAUDE.md ("已在 .gitignore") becomes factually true; also stops these
test artifacts from cluttering `git status`.
- Align workflow stage naming: CLAUDE.md said "TDD" where the rest of
the docs say "execute"; change to "execute(TDD)" to keep TDD visible
while matching docs/superpowers/README.md.
- Add a back-reference from docs/superpowers/README.md to CLAUDE.md so
contributors landing on the README know where the entry point is.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CLAUDE.mdwith chain33-specific conventions for AI-assisted development (Makefile-wrapped git workflow,$GOPATHconstraint, layered map of the 18 code modules, testing discipline, pitfall list).claude/settings.jsonwith a team-shared Claude Code permission allowlist (45 entries: make / go / git-read / search / gh-read). Commands that mutate shared state —git push,make push/sync,gh pr create,git reset --hard,rm,make docker— stay outside the allowlist and continue to promptdocs/superpowers/scaffolding: 1-page README describing the brainstorm → spec → plan → execute → verify workflow, plusspecs/andplans/directories. This PR's own design spec and implementation plan are committed as the first occupants.gitignoreso.claude/settings.json(team config) is tracked while.claude/settings.local.json(personal overrides) stays ignored; also properly ignorescoverage_*.outandbuild/coverage/test artifactsExplicitly out of scope (per spec § 2.2): hooks, custom agents in
.claude/agents/, andCONTRIBUTING-WITH-CLAUDE.md— to be added if real pain points emerge after 1-2 months of use, not speculatively.Test Plan
CLAUDE.mdauto-loads in a new Claude Code session opened in this repomake test,make linter,make fmt,make race,make depends) no longer prompt for permissiongit push,make push,git reset --hardstill prompt every timemake testormake coverage,git statusdoes NOT showcoverage_*.outorbuild/coverage/.claude/settings.local.json(if a developer creates one) is git-ignoredmakecommands referenced inCLAUDE.mdexist inMakefile(verified by acceptance script in plan § Task 4.5)Notes for reviewers
🤖 Generated with Claude Code