Reducing more memory with MINIMIZE_MEMORY - #632
Merged
Conversation
jordanflitter
added
type: performance: memory
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #632 +/- ##
=======================================
Coverage ? 88.17%
=======================================
Files ? 32
Lines ? 4744
Branches ? 801
=======================================
Hits ? 4183
Misses ? 401
Partials ? 160 ☔ View full report in Codecov by Harness. |
jordanflitter
changed the title
steven-murray
left a comment
steven-murray
left a comment
Member
There was a problem hiding this comment.
I think this works, but could be made a little faster by moving some of the conditionals outside loops. See #604 for how I did this (but don't take all the logic from that PR)
steven-murray
approved these changes
Mar 9, 2026
steven-murray
left a comment
steven-murray
left a comment
Member
There was a problem hiding this comment.
I stand corrected -- you have the best implementation here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mean_free_pathandkinetic_temperatureare allocated and computed only ifMINIMIZE_MEMORY=False(these fields are unnecessary for the evaluation of the brightness temperature). This could be useful to @DanielaBreitman.