forked from bitcoin/bitcoin
-
Notifications
You must be signed in to change notification settings - Fork 2
nix: add a native devShell flake #37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| use flake |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,56 @@ | ||
| { | ||
| description = "2140 Bitcoin Core devShell"; | ||
|
|
||
| inputs = { | ||
| nixpkgs.url = "github:NixOS/nixpkgs/nixos-unstable"; | ||
| }; | ||
|
|
||
| outputs = | ||
| { nixpkgs, ... }: | ||
| let | ||
| systems = [ | ||
| "x86_64-linux" | ||
| "aarch64-linux" | ||
| "aarch64-darwin" | ||
| ]; | ||
| forAllSystems = f: nixpkgs.lib.genAttrs systems (system: f (import nixpkgs { inherit system; })); | ||
|
|
||
| mkDevShell = | ||
| pkgs: | ||
| let | ||
| inherit (pkgs) lib; | ||
| inherit (pkgs.stdenv) isLinux isDarwin; | ||
|
|
||
| nativeBuildInputs = [ | ||
| pkgs.ccache | ||
| pkgs.cmakeCurses # cmakeCurses includes the ccmake tool | ||
| pkgs.ninja | ||
| pkgs.pkg-config | ||
| pkgs.python313 | ||
| ] | ||
| ++ lib.optionals isLinux [ | ||
| pkgs.libsystemtap | ||
| pkgs.linuxPackages.bcc | ||
| pkgs.linuxPackages.bpftrace | ||
| ]; | ||
| buildInputs = [ | ||
| pkgs.boost | ||
| pkgs.capnproto | ||
| ]; | ||
| in | ||
| pkgs.mkShell { | ||
| inherit nativeBuildInputs buildInputs; | ||
| hardeningDisable = lib.optionals isDarwin [ "stackclashprotection" ]; | ||
| CMAKE_GENERATOR = "Ninja"; | ||
| CMAKE_EXPORT_COMPILE_COMMANDS = 1; | ||
| LD_LIBRARY_PATH = lib.makeLibraryPath [ pkgs.capnproto ]; | ||
| LOCALE_ARCHIVE = lib.optionalString isLinux "${pkgs.glibcLocales}/lib/locale/locale-archive"; | ||
| }; | ||
|
willcl-ark marked this conversation as resolved.
|
||
| in | ||
| { | ||
| devShells = forAllSystems (pkgs: { | ||
| default = mkDevShell pkgs; | ||
| }); | ||
| formatter = forAllSystems (pkgs: pkgs.nixfmt-tree); | ||
| }; | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it not create a "lot of" churn to include this ? (I get having stable versions is also nice)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd argue
flake.lockis essential for devshells. AFAIU, the lock file is used for the cache, so faster builds, and without the lockfile you're likely to unexpectedly pull in new versions of dependencies (without intending to), which you absolutely don't want while developing.