fix: propagate app settings to subprocess agents - #430
Open
zhengxuyu wants to merge 3 commits into
Open
Conversation
Collaborator
Author
|
Review follow-up: fixed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SubprocessExecutorand the ACP script backend share the same settings-to-environment mappingrun.pystdout failure messageRoot cause
Settingsloaded values from.onemancompany/.envin the parent process, but script children only inherited the shell environment. Under process managers this could leaverun.pywithoutOPENROUTER_API_KEYor another provider key. At the same time,SubprocessExecutoronly inspected stderr, whilestandalone_runner.pyreports missing credentials through stdout, reducing the useful failure toUnknown error.Verification
Quality checklist
core.config.get_settings_environment()is reused by both script backendsFixes #406