Fix quoting math precision loss and exactOut rounding - #137
Open
SovaSlava wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a precision loss bug in
_quoteExactInand corrects the rounding behavior in_quoteExactOutto enforce protocol solvency.Previously, early division by
BPS_BASEcaused premature integer truncation duringExactInquotes, leading to lower output amounts on swaps. Additionally,_quoteExactOutlacked explicit ceiling rounding on fractional input requirements. This fix unifies numerator/denominator scaling and implements native ceil division.Key Changes
_quoteExactIn(Bugfix): Fixed intermediate precision loss by deferringBPS_BASEscaling to the final division step._quoteExactOut(Fix & Solvency): Implemented library-free ceiling division (if (numerator % denominator != 0) { amountIn++; }) to prevent zero-fee/1-sat liquidity extraction on micro-swaps.DIVopcodes) and wrapped fee-multiplier math inuncheckedblocks.Impact
Testing
uint256balances.