fix: stop sync client busy loop after disconnect - #510
Open
gitwillsky wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The synchronous client consumes its internal iterator on a background thread. When Engine.IO
stops, the iterator currently converts
Ok(None)into another error item. With automaticreconnect disabled, the callback loop ignores that error and polls the already-closed transport
again immediately. Each failed connection can therefore leave one busy-looping thread behind.
This change makes a stopped Engine.IO iterator terminal and explicitly stops the callback loop on
poll errors or namespace disconnects when reconnect is disabled. Normal packets do not acquire the
builder lock.
Validation
cargo check -p rust_socketiocargo fmt --all -- --checkand 148-199% CPU
a stable sleeping thread count