feat(hls): add changes to handle secure HLS url#3613
Open
piyush1104 wants to merge 15 commits intomainfrom
Open
feat(hls): add changes to handle secure HLS url#3613piyush1104 wants to merge 15 commits intomainfrom
piyush1104 wants to merge 15 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Add resolutions for immutable, svgo, serialize-javascript, rollup, and update tar and vite to patched versions addressing CVEs for prototype pollution, DoS, path traversal, and RCE vulnerabilities. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Migrate react-sdk, react-icons, hms-whiteboard from rollup to esbuild using the shared build script that other packages already use - Remove rollup, rollup-plugin-terser, rollup-plugin-esbuild, and all @rollup/* plugins as dependencies - Remove src from npm files field across all packages (repo is open source) - Add CSS plugin support to scripts/build.js for whiteboard package - This eliminates rollup 2.x and serialize-javascript from the dep tree, fixing those dependabot alerts at the source Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Replace immutable resolution with sass>=1.83.0 resolution, which depends on immutable@^5.0.2 (not vulnerable). Sass is an unused transitive dependency of esbuild-plugin-postcss2. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
raviteja83
requested changes
Mar 23, 2026
| }, | ||
| "dependencies": { | ||
| "@100mslive/roomkit-react": "0.4.2", | ||
| "@100mslive/roomkit-react": "0.4.3-alpha.4", |
Collaborator
There was a problem hiding this comment.
remove the alpha changes if ready to merge
| userId?: string; | ||
| endpoints?: object; | ||
| effectsSDKKey?: string; | ||
| managementToken?: string; |
Collaborator
There was a problem hiding this comment.
it is easier to read the managementToken by anyone if it is passed. is it only for testing?
| }, [hlsUrl, streamEnded, lastHlsUrl]); | ||
|
|
||
| // Fetch signed URL from passport-api for authenticated CDN streams | ||
| useEffect(() => { |
Collaborator
There was a problem hiding this comment.
move this to a custom hook which returns the resolvedUrl.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.