Conversation
- Restore the dropdown arrow glyph in CEditWindow's dark WM_PAINT path (the short-circuit added in b222ecf stopped the default ComboBox paint from drawing it). - Hoist the duplicated DrawDarkSunkenFrame helper into darkmode.cpp as DarkMode_DrawSunkenFrame; drop the static copies in stswnd.cpp and files_box_view.cpp. - Drop the unreachable second PaintDarkRebarNonClientFrame call in the light branch of MainRebarDarkSubclassProc::WM_NCPAINT.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Release PR for Sally v1.0.13. Three commits, in order:
[build] replace legacy dev tool projects with CMake— Addscmake/sal_dev_tools.cmakewith optionalutfnames,salbreak, andregparserdev-tool targets (allEXCLUDE_FROM_ALL, written underbuild/out/sally/<Config>_<Arch>/devtools/). Removes the legacy.vcxproj/.sln/.propsfiles for these tools and the unused Manison-eraportablesVisual Studio project.plugin_portablesand its language SLG remain unaffected (still produced bysrc/plugins/portables/CMakeLists.txt).doc/DEV.mdupdated with usage and rationale.darkmode: clean up remaining chrome edges— Final polish pass on dark-mode chrome:MainRebarDarkSubclassProcthat paints the client + NC frame, stripsWS_BORDER/RBS_BANDBORDERS, and forcesRBBS_NOGRIPPERon all bands while in dark; reapplies onWM_THEMECHANGED/WM_SYSCOLORCHANGE/WM_SETTINGCHANGE/RB_INSERTBAND/RB_SETBANDINFO.DrawDarkToolbarFrame) instead ofDrawEdge(BDR_*).DWMWA_BORDER_COLOR(Win11), with the existing*Supportedfallback flag pattern.LineDarkrule top and bottom (was a mismatchedLineLight/LineDarkpair).RedrawWindow(... RDW_FRAME ...)invalidations.darkmode: post-review polish— Pre-merge cleanup from the local code review:CEditWindow's darkWM_PAINTpath (theValidateRect/return 0short-circuit had stopped the defaultComboBoxpaint from drawing it).DrawDarkSunkenFramehelper out ofstswnd.cppandfiles_box_view.cppintodarkmode.cppasDarkMode_DrawSunkenFrame.PaintDarkRebarNonClientFramecall in the light branch ofMainRebarDarkSubclassProc::WM_NCPAINT.Will be squash-merged. Tagging
v1.0.13onmainafter merge triggers.github/workflows/release.ymlto build x64/x86/ARM64 RelWithDebInfo and create a draft release with runtime zips, consolidated PDB zip, and translator workspace zip.Test plan
pr-cmake.ymlpasses on Debug x64 + x86 (build, ctest, populate, translation workspace verify).