Skip to content

Sally v1.0.13#57

Merged
0xeb merged 3 commits into
mainfrom
work
May 3, 2026
Merged

Sally v1.0.13#57
0xeb merged 3 commits into
mainfrom
work

Conversation

@0xeb

@0xeb 0xeb commented May 3, 2026

Copy link
Copy Markdown
Owner

Summary

Release PR for Sally v1.0.13. Three commits, in order:

  • [build] replace legacy dev tool projects with CMake — Adds cmake/sal_dev_tools.cmake with optional utfnames, salbreak, and regparser dev-tool targets (all EXCLUDE_FROM_ALL, written under build/out/sally/<Config>_<Arch>/devtools/). Removes the legacy .vcxproj/.sln/.props files for these tools and the unused Manison-era portables Visual Studio project. plugin_portables and its language SLG remain unaffected (still produced by src/plugins/portables/CMakeLists.txt). doc/DEV.md updated with usage and rationale.

  • darkmode: clean up remaining chrome edges — Final polish pass on dark-mode chrome:

    • Top rebar gets a dedicated MainRebarDarkSubclassProc that paints the client + NC frame, strips WS_BORDER/RBS_BANDBORDERS, and forces RBBS_NOGRIPPER on all bands while in dark; reapplies on WM_THEMECHANGED/WM_SYSCOLORCHANGE/WM_SETTINGCHANGE/RB_INSERTBAND/RB_SETBANDINFO.
    • Toolbar buttons and separators now use a flat dark frame (DrawDarkToolbarFrame) instead of DrawEdge(BDR_*).
    • Status bar and items-box draw a dark sunken frame (palette-aware) instead of the system 3D edge.
    • Window border color now plumbed via DWMWA_BORDER_COLOR (Win11), with the existing *Supported fallback flag pattern.
    • Header line uses a single LineDark rule top and bottom (was a mismatched LineLight/LineDark pair).
    • Theme/color changes flush stale frame chrome with targeted RedrawWindow(... RDW_FRAME ...) invalidations.
  • darkmode: post-review polish — Pre-merge cleanup from the local code review:

    • Restored the dropdown-arrow glyph in CEditWindow's dark WM_PAINT path (the ValidateRect/return 0 short-circuit had stopped the default ComboBox paint from drawing it).
    • Hoisted the duplicated DrawDarkSunkenFrame helper out of stswnd.cpp and files_box_view.cpp into darkmode.cpp as DarkMode_DrawSunkenFrame.
    • Dropped the unreachable second PaintDarkRebarNonClientFrame call in the light branch of MainRebarDarkSubclassProc::WM_NCPAINT.

Will be squash-merged. Tagging v1.0.13 on main after merge triggers .github/workflows/release.yml to build x64/x86/ARM64 RelWithDebInfo and create a draft release with runtime zips, consolidated PDB zip, and translator workspace zip.

Test plan

  • Local Release x64 build clean (sally.exe + populate + sal_lang_english).
  • Manual dark-mode smoke: rebar (no double-line, no gripper), toolbar buttons (flat dark frame), address-bar combo (dropdown arrow visible), status bar borders, theme toggle refresh.
  • CI pr-cmake.yml passes on Debug x64 + x86 (build, ctest, populate, translation workspace verify).

0xeb added 3 commits May 2, 2026 09:13
- Restore the dropdown arrow glyph in CEditWindow's dark WM_PAINT path
  (the short-circuit added in b222ecf stopped the default ComboBox
  paint from drawing it).
- Hoist the duplicated DrawDarkSunkenFrame helper into darkmode.cpp as
  DarkMode_DrawSunkenFrame; drop the static copies in stswnd.cpp and
  files_box_view.cpp.
- Drop the unreachable second PaintDarkRebarNonClientFrame call in the
  light branch of MainRebarDarkSubclassProc::WM_NCPAINT.
@0xeb 0xeb merged commit e2b0e4b into main May 3, 2026
6 checks passed
@0xeb 0xeb deleted the work branch May 3, 2026 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant