feat(nix): support selecting model targets in Nix builds - #163
Merged
Conversation
Expose CMake's AUDIOCPP_MODEL_SET/AUDIOCPP_MODELS via a 'models' Nix parameter. Non-empty list auto-sets custom mode; empty defaults to full. CMake OBJECT libraries now use EXCLUDE_FROM_ALL so unselected models are not compiled. Test binary vibevoice_finetune_overlay_check is now gated on vibevoice being linked.
Owner
|
@francescobozzo Merged! Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
AUDIOCPP_MODEL_SET=custom, empty defaults to fullEXCLUDE_FROM_ALLon all model OBJECT libraries so unselected models aren't compiled;vibevoice_finetune_overlay_checknow gated on vibevoice being linked. Note: this change influences all other build pipelines, but was necessary to exclude unwanted models not just from linking but also from compile time.Tests
Validated model list reduces the number of building steps in cmake with the following configuration: