fix: some completion providers send usage chunks with 0 completion choices causing 0 reported usage#1211
Merged
joshua-mo-143 merged 2 commits into0xPlaygrounds:mainfrom Jan 6, 2026
Conversation
Contributor
Author
|
pipeline should be fixed now |
joshua-mo-143
approved these changes
Jan 6, 2026
Contributor
joshua-mo-143
left a comment
joshua-mo-143
left a comment
There was a problem hiding this comment.
Lgtm. Thanks for adding the additional test
joshua-mo-143
changed the title
Merged
ThomasMarches
pushed a commit
to ThomasMarches/rig
that referenced
this pull request
Feb 13, 2026
…oices causing 0 reported usage (0xPlaygrounds#1211) * fix * clippy and fmt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #1212
Proposed fix:
In rig-core/src/providers/openai/completion/streaming.rs, capture data.usage before the choices.first() early-continue, e.g.
if let Some(usage) = data.usage.as_ref() {
final_usage = Some(usage.clone());
}
Add regression test: deserialize a chunk with choices: [] and usage != null and ensure the final streamed usage is not lost.