Investigate file name too long error exception

[betsyecastro]

Error reported by Sentry when user attempted to update their profile picture. See Sentry error

[betsyecastro]

Steps to reproduce:
Upload an image with a filename ~250 character long:

What's happening:
The temp file being renamed had a filename that exceeded Linux's 255-character limit. After investigating the stack trace, the error occurs in PerformConversionAction::renameInLocalDirectory() which is called during the conversion job triggered by toMediaCollection():

public function processImage($new_image, $collection = 'images') {
	    if ($new_image) {
            $this->clearMediaCollection($collection);
            $this->addMedia($new_image)->toMediaCollection($collection);
            $message = 'Profile image has been updated.';
        } else {
            $message = 'Cannot update profile image.';
        }
        return $message;
    }

1. The origin of the filename stored in the DB appears to be a base64 encoded string. The -copy suffix was added by Spatie because the file already existed (most likely because the user attempted the upload twice). First upload — original base64 filename saved to DB: eyJidWNrZXQiOiJzbXAtcHJvZCIsImtleSI6ImV2ZW50cy8xNDBiOTRkYS0yM2YzLTRhZjAtYWRhZC1lYjNkNzQyMTZjZTcvcGhvdG9zL2NvcnJlY3RlZC1icmFuZGVkLzE3NzY0NTI1OTc3NzAtU3R1ZGlvIFNlc3Npb24tMTQ0Ni5qcGciLCJlZGl0cyI6eyJyb3RhdGUiOm51bGwsInZlcnNpb24iOjAsInJlc2l6ZSI6eyJ3a - 245 characters
2. Second upload — Spatie detected the file existed, appended -copy, saved that as the file_name
3. The result of the name stored in the first upload + length("-copy") = 255 exactly, which fit in the DB's VARCHAR(255)
4. Debugging the PerformConversionAction::renameInLocalDirectory() method in the Spatie/Conversions/PerformConversionAction class, shows that when the rename method is called, the file is already stored in the DB, here's when Spatie tries to rename the temp file using the stored file_name from the database and it fails here because the original filename + "-copy" + "-thumb.jpg" = 260 exceeding 255 characters.
5. The defaultSanitizer(string $fileName) runs before saving but only replaces #, /, , and spaces with - but it doesn't truncate the string.
6. generated_conversions stayed empty [] because markAsConversionGenerated() was never called.

Recommendation: to add additional sanitization earlier in the process before the filename is persisted to the DB.