Fix #2500: File Manager UI/UX improvements

This PR addresses multiple issues and feature requests from #2500:

1. Fix PR #2402 Markdown Parser regression (literal colon bug):
   - Changed all dialog templates from <div class="dfm_info"> to <span class="dfm_text">
   - Markdown Extra parser can now handle inline elements without blank line
   - Removed obsolete <dt>/<dd> wrapper structure in Copy/Move templates
   - Cleaned up unused dfm_info CSS rules

2. Show total size of running transfer:
   - Enhanced file_manager rsync parser to calculate total transfer size
   - Averages 5 measurements at different progress points for ~2% accuracy
   - Displays 'Transferring X of Y' during operations

3. Show last N used destination paths in FileTree:
   - New PopularDestinations.php with frequency-based scoring system
   - Displays top 5 recent paths at FileTree root level
   - Automatic FUSE conflict prevention (/mnt/user vs /mnt/diskX)
   - Persistent storage in /boot/config/filemanager.json

4. Manually typing destination path updates FileTree:
   - New setupTargetNavigation() function
   - Navigate FileTree via arrow keys and Enter/Escape
   - Automatic FileTree open/close on input interaction
   - Prevents FileTree from closing when clicking inside dialog

5. Add 'Open Terminal here' button:
   - OpenTerminal.php now accepts path parameter via 'more' GET param
   - Creates custom startup script to set working directory
   - File Manager can open terminal at selected folder

Author: mgutt

emhttp/plugins/dynamix/Browse.page

@@ -13,6 +13,7 @@
 <?
 $docroot ??= ($_SERVER['DOCUMENT_ROOT'] ?: '/usr/local/emhttp');
 require_once "$docroot/webGui/include/Helpers.php";
+require_once "$docroot/plugins/dynamix/include/PopularDestinations.php";
 
 // add translations
 $_SERVER['REQUEST_URI'] = '';
@@ -218,9 +219,19 @@ function quoted($name) {return is_array($name) ? implode(' ',array_map('escape',
     // add task to queue
     $data['task'] = rawurldecode($_POST['task']);
     file_put_contents($jobs, json_encode($data)."\n", FILE_APPEND);
+    
+    // Update popular destinations for copy/move operations
+    if (in_array($data['action'], ['3', '4', '8', '9']) && !empty($data['target'])) {
+      updatePopularDestinations($data['target']);
+    }
   } else {
     // start operation
     file_put_contents($active, json_encode($data));
+    
+    // Update popular destinations for copy/move operations
+    if (in_array($data['action'], ['3', '4', '8', '9']) && !empty($data['target'])) {
+      updatePopularDestinations($data['target']);
+    }
   }
   die();
 }

emhttp/plugins/dynamix/include/Control.php

@@ -50,6 +50,7 @@ function my_dir($name) {
 
 $docroot = '/usr/local/emhttp';
 require_once "$docroot/webGui/include/Secure.php";
+require_once "$docroot/plugins/dynamix/include/PopularDestinations.php";
 
 $mntdir   = '/mnt/';
 $userdir  = '/mnt/user/';
@@ -65,12 +66,49 @@ function my_dir($name) {
 $UDincluded = ['disks','remotes'];
 
 echo "<ul class='jqueryFileTree'>";
-if ($_POST['show_parent'] == 'true' && is_top($rootdir)) {
-  echo "<li class='directory collapsed'>$checkbox<a href='#' rel=\"".htmlspecialchars(dirname($rootdir))."\">..</a></li>";
+
+// Show popular destinations at the top (only at root level and not in autocomplete mode)
+if (!$autocomplete && $rootdir === $root) {
+  $popularPaths = getPopularDestinations(5);
+  
+  // Filter popular paths to prevent FUSE conflicts between /mnt/user and /mnt/diskX
+  if (!empty($popularPaths)) {
+    $isUserContext = (strpos($root, '/mnt/user') === 0 || strpos($root, '/mnt/rootshare') === 0);
+    
+    if ($isUserContext) {
+      // In /mnt/user context: only show /mnt/user paths OR non-/mnt paths (external mounts)
+      $popularPaths = array_filter($popularPaths, function($path) {
+        return (strpos($path, '/mnt/user') === 0 || strpos($path, '/mnt/rootshare') === 0 || strpos($path, '/mnt/') !== 0);
+      });
+    } else if (strpos($root, '/mnt/') === 0) {
+      // In /mnt/diskX or /mnt/cache context: exclude /mnt/user and /mnt/rootshare paths
+      $popularPaths = array_filter($popularPaths, function($path) {
+        return (strpos($path, '/mnt/user') !== 0 && strpos($path, '/mnt/rootshare') !== 0);
+      });
+    }
+    // If root is not under /mnt/, no filtering needed
+  }
+  
+  if (!empty($popularPaths)) {
+    echo "<li class='popular-header small-caps-label' style='list-style:none;padding:5px 0 5px 20px;'>Popular</li>";
+    
+    foreach ($popularPaths as $path) {
+      $pathName = basename($path);
+      $htmlPath = htmlspecialchars($path);
+      $htmlName = htmlspecialchars(mb_strlen($pathName) <= 33 ? $pathName : mb_substr($pathName, 0, 30).'...');
+      // Use data-path instead of rel to prevent jQueryFileTree from handling these links
+      // Use 'directory' class so jQueryFileTree CSS handles the icon
+      echo "<li class='directory popular-destination' style='list-style:none;'>$checkbox<a href='#' data-path='$htmlPath'>$htmlName</a></li>";
+    }
+    
+    // Separator line
+    echo "<li class='popular-separator' style='list-style:none;border-top:1px solid var(--inverse-border-color);margin:5px 0 5px 20px;'></li>";
+  }
 }
 
+// Read directory contents first (needed for both normal and autocomplete mode)
+$dirs = $files = [];
 if (is_dir($rootdir)) {
-  $dirs  = $files = [];
   $names = array_filter(scandir($rootdir, SCANDIR_SORT_NONE), 'no_dots');
   // add UD shares under /mnt/user
   foreach ($UDincluded as $name) {
@@ -89,25 +127,33 @@ function my_dir($name) {
       $files[] = $name;
     }
   }
-  foreach ($dirs as $name) {
-    // Exclude '.Recycle.Bin' from all shares and UD folders from '/mnt'
-    if ($name === '.Recycle.Bin' || ($rootdir === $mntdir && in_array($name, $UDexcluded))) continue;
-    $htmlRel  = htmlspecialchars(my_dir($name).$name);
-    $htmlName = htmlspecialchars(mb_strlen($name) <= 33 ? $name : mb_substr($name, 0, 30).'...');
-    if (empty($match) || preg_match("/$match/", $rootdir.$name.'/')) {
-      echo "<li class='directory collapsed'>$checkbox<a href='#' rel=\"$htmlRel/\">$htmlName</a></li>";
-    }
+}
+
+// Normal mode: show directory tree
+if ($_POST['show_parent'] == 'true' && is_top($rootdir)) {
+  echo "<li class='directory collapsed'>$checkbox<a href='#' rel=\"".htmlspecialchars(dirname($rootdir))."\">..</a></li>";
+}
+
+// Display directories and files (arrays already populated above)
+foreach ($dirs as $name) {
+  // Exclude '.Recycle.Bin' from all shares and UD folders from '/mnt'
+  if ($name === '.Recycle.Bin' || ($rootdir === $mntdir && in_array($name, $UDexcluded))) continue;
+  $htmlRel  = htmlspecialchars(my_dir($name).$name);
+  $htmlName = htmlspecialchars(mb_strlen($name) <= 33 ? $name : mb_substr($name, 0, 30).'...');
+  if (empty($match) || preg_match("/$match/", $rootdir.$name.'/')) {
+    echo "<li class='directory collapsed'>$checkbox<a href='#' rel=\"$htmlRel/\">$htmlName</a></li>";
   }
-  foreach ($files as $name) {
-    $htmlRel  = htmlspecialchars(my_dir($name).$name);
-    $htmlName = htmlspecialchars($name);
-    $ext      = mb_strtolower(pathinfo($name, PATHINFO_EXTENSION));
-    foreach ($filters as $filter) if (empty($filter) || $ext === $filter) {
-      if (empty($match) || preg_match("/$match/", $name)) {
-        echo "<li class='file ext_$ext'>$checkbox<a href='#' rel=\"$htmlRel\">$htmlName</a></li>";
-      }
+}
+foreach ($files as $name) {
+  $htmlRel  = htmlspecialchars(my_dir($name).$name);
+  $htmlName = htmlspecialchars($name);
+  $ext      = mb_strtolower(pathinfo($name, PATHINFO_EXTENSION));
+  foreach ($filters as $filter) if (empty($filter) || $ext === $filter) {
+    if (empty($match) || preg_match("/$match/", $name)) {
+      echo "<li class='file ext_$ext'>$checkbox<a href='#' rel=\"$htmlRel\">$htmlName</a></li>";
     }
   }
 }
+
 echo "</ul>";
 ?>

emhttp/plugins/dynamix/include/FileTree.php

@@ -51,7 +51,43 @@ function command($path,$file) {
     // no child processes, restart ttyd to pick up possible font size change
     if ($retval != 0) exec("kill ".$ttyd_pid[0]);
   }
-  if ($retval != 0) exec("ttyd-exec -i '$sock' '" . posix_getpwuid(0)['shell'] . "' --login");
+  
+  $more = $_GET['more'] ?? '';
+  if (!empty($more) && substr($more, 0, 1) === '/') {
+    // Terminal at specific path - use 'more' parameter to pass path
+    // Note: openTerminal(tag, name, more) in JS only has 3 params, so we reuse 'more'
+    // Note: Used by File Manager to open terminal at specific folder
+    
+    // Validate path
+    $real_path = realpath($more);
+    if ($real_path === false) {
+      // Path doesn't exist - fall back to home directory
+      $real_path = '/root';
+    }
+    
+    $name = unbundle($_GET['name']);
+    $exec = "/var/tmp/$name.run.sh";
+    $escaped_path = str_replace("'", "'\\''", $real_path);
+    
+    // Create startup script similar to ~/.bashrc
+    // Note: We can not use ~/.bashrc as it loads /etc/profile which does 'cd $HOME'
+    $script_content = <<<BASH
+#!/bin/bash
+# Modify /etc/profile to replace 'cd \$HOME' with our target path
+sed 's#^cd \$HOME#cd '\''$escaped_path'\''#' /etc/profile > /tmp/$name.profile
+source /tmp/$name.profile
+source /root/.bash_profile 2>/dev/null
+rm /tmp/$name.profile
+exec bash --norc -i
+BASH;
+    
+    file_put_contents($exec, $script_content);
+    chmod($exec, 0755);
+    exec("ttyd-exec -i '$sock' $exec");
+  } else {
+    // Standard login shell
+    if ($retval != 0) exec("ttyd-exec -i '$sock' '" . posix_getpwuid(0)['shell'] . "' --login");
+  }
   break;
 case 'syslog':
   // read syslog file

emhttp/plugins/dynamix/include/OpenTerminal.php

@@ -0,0 +1,139 @@
+<?PHP
+/* Copyright 2005-2025, Lime Technology
+ * Copyright 2012-2025, Bergware International.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License version 2,
+ * as published by the Free Software Foundation.
+ *
+ * The above copyright notice and this permission notice shall be included in
+ * all copies or substantial portions of the Software.
+ */
+?>
+<?
+// Popular Destinations Management for File Manager
+// Uses frequency-based scoring with decay
+
+define('POPULAR_DESTINATIONS_FILE', '/boot/config/filemanager.json');
+define('SCORE_INCREMENT', 10);
+define('SCORE_DECAY', 1);
+define('MAX_ENTRIES', 50);
+
+/**
+ * Load popular destinations from JSON file
+ */
+function loadPopularDestinations() {
+  if (!file_exists(POPULAR_DESTINATIONS_FILE)) {
+    return ['destinations' => []];
+  }
+  
+  $json = file_get_contents(POPULAR_DESTINATIONS_FILE);
+  $data = json_decode($json, true);
+  
+  if (!is_array($data) || !isset($data['destinations'])) {
+    return ['destinations' => []];
+  }
+  
+  return $data;
+}
+
+/**
+ * Save popular destinations to JSON file
+ */
+function savePopularDestinations($data) {
+  $json = json_encode($data, JSON_PRETTY_PRINT | JSON_UNESCAPED_SLASHES);
+  file_put_contents(POPULAR_DESTINATIONS_FILE, $json);
+}
+
+/**
+ * Update popular destinations when a job is started
+ * @param string $targetPath The destination path used in copy/move operation
+ */
+function updatePopularDestinations($targetPath) {
+  // Skip empty paths or paths that are just /mnt or /boot
+  if (empty($targetPath) || $targetPath == '/mnt' || $targetPath == '/boot') {
+    return;
+  }
+  
+  // Normalize path (remove trailing slash)
+  $targetPath = rtrim($targetPath, '/');
+  
+  // Load current data
+  $data = loadPopularDestinations();
+  $destinations = $data['destinations'];
+  
+  // Find target path first (before decay)
+  $found = false;
+  $targetIndex = -1;
+  foreach ($destinations as $index => $dest) {
+    if ($dest['path'] === $targetPath) {
+      $found = true;
+      $targetIndex = $index;
+      break;
+    }
+  }
+  
+  // Decay all scores by 1 (except the target path which we'll increment)
+  foreach ($destinations as $index => &$dest) {
+    if ($index !== $targetIndex) {
+      $dest['score'] -= SCORE_DECAY;
+    } else {
+      // Target path: increment instead of decaying
+      $dest['score'] += SCORE_INCREMENT;
+    }
+  }
+  unset($dest);
+  
+  // If path not found, add it
+  if (!$found) {
+    $destinations[] = [
+      'path' => $targetPath,
+      'score' => SCORE_INCREMENT
+    ];
+  }
+  
+  // Remove entries with score <= 0
+  $destinations = array_filter($destinations, function($dest) {
+    return $dest['score'] > 0;
+  });
+  
+  // Sort by score descending
+  usort($destinations, function($a, $b) {
+    return $b['score'] - $a['score'];
+  });
+  
+  // Keep only MAX_ENTRIES
+  if (count($destinations) > MAX_ENTRIES) {
+    $destinations = array_slice($destinations, 0, MAX_ENTRIES);
+  }
+  
+  // Re-index array
+  $destinations = array_values($destinations);
+  
+  // Save
+  $data['destinations'] = $destinations;
+  savePopularDestinations($data);
+}
+
+/**
+ * Get top N popular destinations
+ * @param int $limit Maximum number of destinations to return (default 5)
+ * @return array Array of destination paths
+ */
+function getPopularDestinations($limit = 5) {
+  $data = loadPopularDestinations();
+  $destinations = $data['destinations'];
+  
+  // Sort by score descending (should already be sorted, but just in case)
+  usort($destinations, function($a, $b) {
+    return $b['score'] - $a['score'];
+  });
+  
+  // Return top N paths
+  $result = array_slice($destinations, 0, $limit);
+  
+  return array_map(function($dest) {
+    return $dest['path'];
+  }, $result);
+}
+?>